Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Issue 1903733004: Exclude any *_test.dart and */test/*dart when creating stamp files for pkg and third_party/pkg. (Closed)

Created:
4 years, 8 months ago by ahe
Modified:
4 years, 8 months ago
Reviewers:
Bill Hesse, kustermann
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Exclude any *_test.dart and */test/*dart when creating stamp files for pkg and third_party/pkg. R=whesse@google.com Committed: https://github.com/dart-lang/sdk/commit/7f4e76a4048bf2180d229ee5c0b4d570bfe00a18

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M pkg/pkg_files.gyp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
ahe
Based on this Dartino patch: https://codereview.chromium.org/1459893002 I'm now trying to land this in master.
4 years, 8 months ago (2016-04-20 16:08:54 UTC) #2
Bill Hesse
LGTM.
4 years, 8 months ago (2016-04-20 16:29:49 UTC) #3
ahe
4 years, 8 months ago (2016-04-21 07:24:13 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7f4e76a4048bf2180d229ee5c0b4d570bfe00a18 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698