Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 1459893002: Exclude any *_test.dart and */test/*dart when creating stamp files for pkg and third_party/pkg (Closed)

Created:
5 years, 1 month ago by kustermann
Modified:
5 years, 1 month ago
Reviewers:
erikcorry
CC:
ahe, fletch+reviews_googlegroups.com, sigurdm
Base URL:
https://github.com/dart-lang/sdk.git@_temporary_fletch_patches
Target Ref:
refs/heads/_temporary_fletch_patches
Visibility:
Public.

Description

Exclude any *_test.dart and */test/*dart when creating stamp files for pkg and third_party/pkg BUG= R=erikcorry@google.com Committed: https://github.com/dart-lang/sdk/commit/34357cdad108dcba734949bd13bd28c76ea285e0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M pkg/pkg_files.gyp View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
kustermann
5 years, 1 month ago (2015-11-19 13:33:39 UTC) #2
kustermann
This will make us not cross the limit of xcodebuild which causes our sdk builders ...
5 years, 1 month ago (2015-11-19 13:35:24 UTC) #3
erikcorry
lgtm
5 years, 1 month ago (2015-11-19 13:53:06 UTC) #4
kustermann
5 years, 1 month ago (2015-11-19 14:24:51 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
34357cdad108dcba734949bd13bd28c76ea285e0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698