[stubs]: Implement ArrayNoArgumentConstructor as a TF stub

[stubs]: Implement ArrayNoArgumentConstructor as a TF stub

Committed: https://crrev.com/fa570e55b623c74245945e3bdda042df1bf6a196
Cr-Commit-Position: refs/heads/master@{#35963}

[danno, 2016-05-02 09:42:41]

danno@chromium.org changed reviewers:
+ bmeurer@chromium.org, mvstanton@chromium.org

[danno, 2016-05-02 09:42:42]

PTAL

[mvstanton, 2016-05-02 12:40:08]

One nit, then LGTM.

Quick question: are there plans to move the other two stubs over, or instead to
just set up slow paths for them? (ie, runtime calls).
Thx!
--Mike

https://codereview.chromium.org/1903723003/diff/140001/src/code-stubs.cc
File src/code-stubs.cc (right):

https://codereview.chromium.org/1903723003/diff/140001/src/code-stubs.cc#newc...
src/code-stubs.cc:4256: Node* native_context =
assembler->LoadObjectField(assembler->Parameter(0),
It would be better if the interface descriptor has a name for each index, like
kContext, kAllocationSite, kArgumentCount.

[danno, 2016-05-02 15:26:21]

Middle-term, all of the constructors will move to TF, at least the fixed
arguments count ones. The N argument count one will probably just call the
runtime if possible, but we'll cross that bridge when we get to it.

https://codereview.chromium.org/1903723003/diff/140001/src/code-stubs.cc
File src/code-stubs.cc (right):

https://codereview.chromium.org/1903723003/diff/140001/src/code-stubs.cc#newc...
src/code-stubs.cc:4256: Node* native_context =
assembler->LoadObjectField(assembler->Parameter(0),
On 2016/05/02 12:40:08, mvstanton wrote:
> It would be better if the interface descriptor has a name for each index, like
> kContext, kAllocationSite, kArgumentCount.

Done.

[danno, 2016-05-02 15:50:21]

Benedikt, you OK with this?

[Benedikt Meurer, 2016-05-03 03:57:49]

LGTM with comment/nit.

https://codereview.chromium.org/1903723003/diff/160001/src/code-stub-assemble...
File src/code-stub-assembler.cc (right):

https://codereview.chromium.org/1903723003/diff/160001/src/code-stub-assemble...
src/code-stub-assembler.cc:616: index = ChangeInt32ToInt64(index);
How about adding a ChangeInt32ToIntPtr helper that encapsulates this 32 vs
64-bit magic?

https://codereview.chromium.org/1903723003/diff/160001/src/code-stub-assembler.h
File src/code-stub-assembler.h (right):

https://codereview.chromium.org/1903723003/diff/160001/src/code-stub-assemble...
src/code-stub-assembler.h:192: void CreateAllocationMemento(compiler::Node*
base_allocation,
Nit: Can we rename this guy to sth like InitializeAllocationMemento or
SetupAllocationMemento?

[danno, 2016-05-03 07:10:48]

Thanks, feedback address. Landing.

https://codereview.chromium.org/1903723003/diff/160001/src/code-stub-assemble...
File src/code-stub-assembler.cc (right):

https://codereview.chromium.org/1903723003/diff/160001/src/code-stub-assemble...
src/code-stub-assembler.cc:616: index = ChangeInt32ToInt64(index);
On 2016/05/03 03:57:49, Benedikt Meurer wrote:
> How about adding a ChangeInt32ToIntPtr helper that encapsulates this 32 vs
> 64-bit magic?

Done.

https://codereview.chromium.org/1903723003/diff/160001/src/code-stub-assembler.h
File src/code-stub-assembler.h (right):

https://codereview.chromium.org/1903723003/diff/160001/src/code-stub-assemble...
src/code-stub-assembler.h:192: void CreateAllocationMemento(compiler::Node*
base_allocation,
On 2016/05/03 03:57:49, Benedikt Meurer wrote:
> Nit: Can we rename this guy to sth like InitializeAllocationMemento or
> SetupAllocationMemento?

Done.

[danno, 2016-05-03 07:10:57]

The CQ bit was checked by danno@chromium.org

[danno, 2016-05-03 07:10:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
mvstanton@chromium.org, bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/1903723003/#ps180001
(title: "Review feedback")

[commit-bot: I haz the power, 2016-05-03 07:11:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1903723003/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1903723003/180001

[commit-bot: I haz the power, 2016-05-03 07:16:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-03 07:16:47]

Try jobs failed on following builders:
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/14524)

[Hannes Payer (out of office), 2016-05-03 07:55:21]

hpayer@chromium.org changed reviewers:
+ hpayer@chromium.org

[Hannes Payer (out of office), 2016-05-03 07:55:22]

lgtm

[danno, 2016-05-03 07:56:23]

The CQ bit was checked by danno@chromium.org

[commit-bot: I haz the power, 2016-05-03 07:56:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1903723003/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1903723003/180001

[commit-bot: I haz the power, 2016-05-03 07:59:33]

Committed patchset #10 (id:180001)

[commit-bot: I haz the power, 2016-05-03 08:00:55]

Description was changed from

==========
[stubs]: Implement ArrayNoArgumentConstructor as a TF stub
==========

to

==========
[stubs]: Implement ArrayNoArgumentConstructor as a TF stub

Committed: https://crrev.com/fa570e55b623c74245945e3bdda042df1bf6a196
Cr-Commit-Position: refs/heads/master@{#35963}
==========

[commit-bot: I haz the power, 2016-05-03 08:00:56]

Patchset 10 (id:??) landed as
https://crrev.com/fa570e55b623c74245945e3bdda042df1bf6a196
Cr-Commit-Position: refs/heads/master@{#35963}