Add onImageInfo call to SkImage_Base.

Add onImageInfo call to SkImage_Base.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1903483003

Committed: https://skia.googlesource.com/skia/+/a7c9d6303a4bd3bda9d7b3f73334f182b11338c4

[herb_g, 2016-04-19 16:23:48]

Description was changed from

==========
Add onImageInfo call to SkImage_Base.

BUG=skia:
==========

to

==========
Add onImageInfo call to SkImage_Base.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[herb_g, 2016-04-19 16:28:49]

Remove ImageInfo changes.

[herb_g, 2016-04-19 16:32:31]

The CQ bit was checked by herb@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-19 16:32:37]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1903483003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1903483003/20001

[herb_g, 2016-04-19 16:33:07]

herb@google.com changed reviewers:
+ reed@google.com, robertphillips@google.com

[herb_g, 2016-04-19 16:33:46]

Description was changed from

==========
Add onImageInfo call to SkImage_Base.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Add onImageInfo call to SkImage_Base.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[msarett, 2016-04-19 16:42:44]

msarett@google.com changed reviewers:
+ msarett@google.com

[msarett, 2016-04-19 16:42:44]

I think I'd prefer if we exposed the SkEncodedInfo (though this just got
reverted - I need to fix and reland https://codereview.chromium.org/1820073002/)
and/or the SkColorSpace (though maybe we're not ready for this yet).

IMO, SkImageInfo does a bad job of describing encoded data.  Any thoughts?

[commit-bot: I haz the power, 2016-04-19 16:48:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-19 16:48:49]

Dry run: This issue passed the CQ dry run.

[herb_g, 2016-04-19 17:05:23]

I looked at SkEncodedInfo, and it doesn't seem to have any profile information.
How do I detect if it is linear or sRGB, and in the future how do I detect a
general profile?

[msarett, 2016-04-19 17:22:15]

Looking forward, I think it's nice to keep the color space in a separate object
- since it will eventually be more than just sRGB vs. Linear.

The SkColorSpace is exposed on SkCodec but is not passed through to
SkImageGenerator/SkImage.

We do have a hack in SkCodecImageGenerator to convert the SkColorSpace to an
enum on an SkImageInfo...  Going along with this, what you've proposed may be
the right thing to do.

But ideally, I'd like to see us stop using SkImageInfo and use SkColorSpace
instead.  Not sure how much work this would be, or if you would run into
problems given that SkColorSpace isn't public yet.

[herb_g, 2016-04-19 19:17:52]

On 2016/04/19 17:22:15, msarett wrote:
> Looking forward, I think it's nice to keep the color space in a separate
object
> - since it will eventually be more than just sRGB vs. Linear.
> 
> The SkColorSpace is exposed on SkCodec but is not passed through to
> SkImageGenerator/SkImage.
> 
> We do have a hack in SkCodecImageGenerator to convert the SkColorSpace to an
> enum on an SkImageInfo...  Going along with this, what you've proposed may be
> the right thing to do.
> 
> But ideally, I'd like to see us stop using SkImageInfo and use SkColorSpace
> instead.  Not sure how much work this would be, or if you would run into
> problems given that SkColorSpace isn't public yet.

I think this change is needed because the Blitter needs to understand the pixel
data to sample that is already picked, and SkImageInfo is the way the blitters
understand Src.

[reed1, 2016-04-19 19:28:47]

lgtm

[herb_g, 2016-04-19 19:29:19]

The CQ bit was checked by herb@google.com

[commit-bot: I haz the power, 2016-04-19 19:29:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1903483003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1903483003/20001

[commit-bot: I haz the power, 2016-04-19 19:30:24]

Description was changed from

==========
Add onImageInfo call to SkImage_Base.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Add onImageInfo call to SkImage_Base.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/a7c9d6303a4bd3bda9d7b3f73334f182b11338c4
==========

[commit-bot: I haz the power, 2016-04-19 19:30:25]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/a7c9d6303a4bd3bda9d7b3f73334f182b11338c4