Make all the codecs default profiles based on gDefaultProfileIsSRGB.

Make all the codecs default profiles based on gTreatSkColorAsSRGB.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1893203006

Committed: https://skia.googlesource.com/skia/+/9bc22351b59a77d9cafb0bccf69aac84425a7503

[herb_g, 2016-04-19 19:26:48]

Description was changed from

==========
Make all the codecs default profiles based on gTreatSkColorAsSRGB.

BUG=skia:
==========

to

==========
Make all the codecs default profiles based on gTreatSkColorAsSRGB.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[herb_g, 2016-04-19 21:19:49]

Working

[herb_g, 2016-04-19 21:55:07]

Description was changed from

==========
Make all the codecs default profiles based on gTreatSkColorAsSRGB.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Make all the codecs default profiles based on gTreatSkColorAsSRGB.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[herb_g, 2016-04-19 21:55:07]

herb@google.com changed reviewers:
+ msarett@google.com, reed@google.com

[msarett, 2016-04-20 16:08:24]

lgtm

[herb_g, 2016-04-20 16:39:41]

The CQ bit was checked by herb@google.com

[commit-bot: I haz the power, 2016-04-20 16:39:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1893203006/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1893203006/20001

[commit-bot: I haz the power, 2016-04-20 16:41:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-20 16:41:17]

Try jobs failed on following builders:
  skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED,
http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)

[herb_g, 2016-04-20 17:56:11]

On 2016/04/20 16:41:17, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED,
>
http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)

As per our discussion.
1) Use a separate global for controlling the default behavior of the codecs.
2) Move default profile to the newly created SkImageInfoPriv.h

Near future:
Harden the l32 pipeline against sRGB based on either the surface properties or
the colorType.

[herb_g, 2016-04-20 18:35:24]

Moved to own global.

[herb_g, 2016-04-20 18:36:37]

Revert SkImageInfo.h

[herb_g, 2016-04-20 18:56:19]

Remove unneeded include.

[herb_g, 2016-04-20 18:56:42]

The CQ bit was checked by herb@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-20 18:56:50]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1893203006/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1893203006/80001

[commit-bot: I haz the power, 2016-04-20 18:58:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-20 18:58:01]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-Trybot on client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-ShuttleA-GPU...)
  Build-Mac-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-x86_...)
  Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x...)

[reed1, 2016-04-20 19:44:30]

lgtm

[herb_g, 2016-04-20 21:46:01]

Switch to use SkEncodingInfo.

[herb_g, 2016-04-20 21:46:28]

The CQ bit was checked by herb@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-20 21:46:38]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1893203006/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1893203006/100001

[commit-bot: I haz the power, 2016-04-20 21:47:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-20 21:47:49]

Dry run: Try jobs failed on following builders:
  Build-Mac-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-x86_...)
  Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x...)
  Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)
  Build-Ubuntu-GCC-Mips-Debug-Android-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Mip...)
  Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)

[herb_g, 2016-04-20 21:55:21]

Make private work.

[herb_g, 2016-04-20 21:55:36]

The CQ bit was checked by herb@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-20 21:55:39]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1893203006/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1893203006/120001

[commit-bot: I haz the power, 2016-04-20 22:05:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-20 22:05:50]

Dry run: This issue passed the CQ dry run.

[herb_g, 2016-04-20 22:06:30]

The CQ bit was checked by herb@google.com

[herb_g, 2016-04-20 22:06:30]

The patchset sent to the CQ was uploaded after l-g-t-m from msarett@google.com,
reed@google.com
Link to the patchset: https://codereview.chromium.org/1893203006/#ps120001
(title: "Make private work.")

[commit-bot: I haz the power, 2016-04-20 22:06:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1893203006/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1893203006/120001

[commit-bot: I haz the power, 2016-04-20 22:07:37]

Description was changed from

==========
Make all the codecs default profiles based on gTreatSkColorAsSRGB.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Make all the codecs default profiles based on gTreatSkColorAsSRGB.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/9bc22351b59a77d9cafb0bccf69aac84425a7503
==========

[commit-bot: I haz the power, 2016-04-20 22:07:38]

Committed patchset #7 (id:120001) as
https://skia.googlesource.com/skia/+/9bc22351b59a77d9cafb0bccf69aac84425a7503

[Brian Osman, 2016-04-21 13:33:36]

brianosman@google.com changed reviewers:
+ brianosman@google.com

[Brian Osman, 2016-04-21 13:33:37]

https://codereview.chromium.org/1893203006/diff/120001/src/core/SkBitmap.cpp
File src/core/SkBitmap.cpp (right):

https://codereview.chromium.org/1893203006/diff/120001/src/core/SkBitmap.cpp#...
src/core/SkBitmap.cpp:750: dst.setInfo(SkImageInfo::Make(subset.width(),
subset.height(),
Sorry, I just went back and looked at this change more carefully. Does this do
anything different? (The rest of the review makes sense - just wasn't sure why
this file was modified like this).

[herb_g, 2016-04-21 15:09:54]

https://codereview.chromium.org/1893203006/diff/120001/src/core/SkBitmap.cpp
File src/core/SkBitmap.cpp (right):

https://codereview.chromium.org/1893203006/diff/120001/src/core/SkBitmap.cpp#...
src/core/SkBitmap.cpp:750: dst.setInfo(SkImageInfo::Make(subset.width(),
subset.height(),
On 2016/04/21 13:33:37, Brian Osman wrote:
> Sorry, I just went back and looked at this change more carefully. Does this do
> anything different? (The rest of the review makes sense - just wasn't sure why
> this file was modified like this).

No This is a regression probably from one of the may rebases I did. I will put
it back.