src/compiler.cc - Issue 1903463002: Make global eval faster by lazily computing its call position.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler.cc

Issue 1903463002: Make global eval faster by lazily computing its call position. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler.cc

diff --git a/src/compiler.cc b/src/compiler.cc

index da4ab78eb6eaf6caa5a8c94dca7fefdc8dc4ecd2..3bda70cdc68d36c5e1c4d9c6bd1d0c4ea5e5250c 100644

--- a/src/compiler.cc

+++ b/src/compiler.cc

@@ -1260,8 +1260,7 @@ MaybeHandle<JSFunction> Compiler::GetFunctionFromEval(

}

script->set_origin_options(options);

script->set_compilation_type(Script::COMPILATION_TYPE_EVAL);

- script->set_eval_from_shared(*outer_info);

- script->set_eval_from_position(eval_position);

+ Script::SetEvalOrigin(script, outer_info, eval_position);

Zone zone(isolate->allocator());

ParseInfo parse_info(&zone, script);

« no previous file with comments | « src/builtins.cc ('k') | src/objects.h » ('j') | no next file with comments »