Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(959)

Unified Diff: src/builtins.cc

Issue 1903463002: Make global eval faster by lazily computing its call position. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/accessors.cc ('k') | src/compiler.cc » ('j') | src/compiler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/builtins.cc
diff --git a/src/builtins.cc b/src/builtins.cc
index 71cb617d017081fa7d72ef301882bcf78d419483..20de25b8bc02917c429009d089cddf8e21248716 100644
--- a/src/builtins.cc
+++ b/src/builtins.cc
@@ -2067,19 +2067,9 @@ MaybeHandle<JSFunction> CompileString(Handle<Context> context,
}
// Compile source string in the native context.
- StackTraceFrameIterator it(isolate);
int eval_scope_position = 0;
int eval_position = RelocInfo::kNoPosition;
- Handle<SharedFunctionInfo> outer_info;
- if (!it.done() && it.is_javascript()) {
- FrameSummary summary = FrameSummary::GetFirst(it.javascript_frame());
- eval_position =
- summary.abstract_code()->SourcePosition(summary.code_offset());
- outer_info = Handle<SharedFunctionInfo>(summary.function()->shared());
- } else {
- outer_info =
- Handle<SharedFunctionInfo>(native_context->closure()->shared());
- }
+ Handle<SharedFunctionInfo> outer_info(native_context->closure()->shared());
return Compiler::GetFunctionFromEval(source, outer_info, native_context,
SLOPPY, restriction, eval_scope_position,
eval_position);
« no previous file with comments | « src/accessors.cc ('k') | src/compiler.cc » ('j') | src/compiler.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698