Make global eval faster by lazily computing its call position.

Make global eval faster by lazily computing its call position.

Prior to 89d7bfda we always just collected the code offset and computed the
source position lazily. However, for local eval we already have the source
position ready, so we can just store that. For global eval we still have to
compute from the code offset. This CL changes the computation to be done only
on demand.

R=mstarzinger@chromium.org
BUG=chromium:604646
LOG=N

Committed: https://crrev.com/91e2bf6e37c32f9e0a3afacf155c77a4b704f087
Cr-Commit-Position: refs/heads/master@{#35630}

[Michael Starzinger, 2016-04-19 13:39:33]

https://codereview.chromium.org/1903463002/diff/1/src/compiler.cc
File src/compiler.cc (right):

https://codereview.chromium.org/1903463002/diff/1/src/compiler.cc#newcode1249
src/compiler.cc:1249: compilation_cache->LookupEval(source, outer_info, context,
language_mode,
This will perform a compilation cache lookup with a key containing the
SharedFunctionInfo for the top-level function always, independent from where the
global eval has been called. Is this safe?

[Yang, 2016-04-19 13:45:06]

On 2016/04/19 13:39:33, Michael Starzinger wrote:
> https://codereview.chromium.org/1903463002/diff/1/src/compiler.cc
> File src/compiler.cc (right):
> 
> https://codereview.chromium.org/1903463002/diff/1/src/compiler.cc#newcode1249
> src/compiler.cc:1249: compilation_cache->LookupEval(source, outer_info,
context,
> language_mode,
> This will perform a compilation cache lookup with a key containing the
> SharedFunctionInfo for the top-level function always, independent from where
the
> global eval has been called. Is this safe?

Yes. In fact, this was the old behavior in the first place:
https://codereview.chromium.org/1854713002/diff/200001/src/builtins.cc

[Yang, 2016-04-19 13:45:09]

On 2016/04/19 13:39:33, Michael Starzinger wrote:
> https://codereview.chromium.org/1903463002/diff/1/src/compiler.cc
> File src/compiler.cc (right):
> 
> https://codereview.chromium.org/1903463002/diff/1/src/compiler.cc#newcode1249
> src/compiler.cc:1249: compilation_cache->LookupEval(source, outer_info,
context,
> language_mode,
> This will perform a compilation cache lookup with a key containing the
> SharedFunctionInfo for the top-level function always, independent from where
the
> global eval has been called. Is this safe?

Yes. In fact, this was the old behavior in the first place:
https://codereview.chromium.org/1854713002/diff/200001/src/builtins.cc

[Michael Starzinger, 2016-04-19 13:48:35]

On 2016/04/19 13:45:09, Yang wrote:
> On 2016/04/19 13:39:33, Michael Starzinger wrote:
> > https://codereview.chromium.org/1903463002/diff/1/src/compiler.cc
> > File src/compiler.cc (right):
> > 
> >
https://codereview.chromium.org/1903463002/diff/1/src/compiler.cc#newcode1249
> > src/compiler.cc:1249: compilation_cache->LookupEval(source, outer_info,
> context,
> > language_mode,
> > This will perform a compilation cache lookup with a key containing the
> > SharedFunctionInfo for the top-level function always, independent from where
> the
> > global eval has been called. Is this safe?
> 
> Yes. In fact, this was the old behavior in the first place:
> https://codereview.chromium.org/1854713002/diff/200001/src/builtins.cc

Ack. Thanks for the clarification.

[Michael Starzinger, 2016-04-19 13:48:47]

LGTM.

[Yang, 2016-04-19 13:51:29]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-19 13:51:40]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1903463002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1903463002/1

[Yang, 2016-04-19 15:30:50]

The CQ bit was unchecked by yangguo@chromium.org

[Yang, 2016-04-19 15:30:55]

The CQ bit was checked by yangguo@chromium.org

[commit-bot: I haz the power, 2016-04-19 15:31:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1903463002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1903463002/1

[commit-bot: I haz the power, 2016-04-19 16:16:40]

Committed patchset #1 (id:1)

[nodir1, 2016-04-22 18:43:10]

Description was changed from

==========
Make global eval faster by lazily computing its call position.

Prior to 89d7bfda we always just collected the code offset and computed the
source position lazily. However, for local eval we already have the source
position ready, so we can just store that. For global eval we still have to
compute from the code offset. This CL changes the computation to be done only
on demand.

R=mstarzinger@chromium.org
BUG=chromium:604646
LOG=N
==========

to

==========
Make global eval faster by lazily computing its call position.

Prior to 89d7bfda we always just collected the code offset and computed the
source position lazily. However, for local eval we already have the source
position ready, so we can just store that. For global eval we still have to
compute from the code offset. This CL changes the computation to be done only
on demand.

R=mstarzinger@chromium.org
BUG=chromium:604646
LOG=N

Committed: https://crrev.com/91e2bf6e37c32f9e0a3afacf155c77a4b704f087
Cr-Commit-Position: refs/heads/master@{#35630}
==========

[nodir1, 2016-04-22 18:43:11]

Patchset 1 (id:??) landed as
https://crrev.com/91e2bf6e37c32f9e0a3afacf155c77a4b704f087
Cr-Commit-Position: refs/heads/master@{#35630}