Issue 190333002: Reset media controls when load() is called

Issue 190333002: Reset media controls when load() is called (Closed)

Created:
6 years, 9 months ago by philipj_slow

Modified:
6 years, 9 months ago

Reviewers:
acolwell GONE FROM CHROMIUM

CC:
blink-reviews, nessy, philipj_slow, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, adamk+blink_chromium.org, vcarbune.chromium

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Reset media controls when load() is called Calling reset() in configureMediaControls() is a slightly bigger hammer than should be needed, but it isn't called very often so it shouldn't matter in practice. Ideally MediaControls should be hooked to the same fine-grained events as scripts see, but that's for the future. BUG=350310 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168776

Patch Set 1 #

Total comments: 4

Patch Set 2 : nits #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -0 lines)			Patch
A	LayoutTests/media/controls-after-unload.html	View	1	1 chunk	+35 lines, -0 lines	0 comments	Download
A	LayoutTests/media/controls-after-unload-expected.html	View		1 chunk	+9 lines, -0 lines	0 comments	Download
M	Source/core/html/HTMLMediaElement.cpp	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 16 (0 generated)

Expand Messages | Collapse Messages

acolwell GONE FROM CHROMIUM

lgtm % nits https://codereview.chromium.org/190333002/diff/1/LayoutTests/media/controls-after-unload.html File LayoutTests/media/controls-after-unload.html (right): https://codereview.chromium.org/190333002/diff/1/LayoutTests/media/controls-after-unload.html#newcode7 LayoutTests/media/controls-after-unload.html:7: <body onload="test()"> nit: Why is this ...

6 years, 9 months ago (2014-03-07 17:45:03 UTC) #2

philipj_slow

https://codereview.chromium.org/190333002/diff/1/LayoutTests/media/controls-after-unload.html File LayoutTests/media/controls-after-unload.html (right): https://codereview.chromium.org/190333002/diff/1/LayoutTests/media/controls-after-unload.html#newcode7 LayoutTests/media/controls-after-unload.html:7: <body onload="test()"> On 2014/03/07 17:45:04, acolwell wrote: > nit: ...

6 years, 9 months ago (2014-03-07 18:39:38 UTC) #3