LayoutTests/media/controls-after-unload.html - Issue 190333002: Reset media controls when load() is called

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/media/controls-after-unload.html

Issue 190333002: Reset media controls when load() is called (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 <!doctype html>

	2 <html>

	3 <head>

	4 <title>controls after unload</title>

	5 <script src=media-file.js></script>

	6 </head>

	7 <body onload="test()">
	acolwell GONE FROM CHROMIUM 2014/03/07 17:45:04 nit: Why is this needed? It doesn't look like test nit: Why is this needed? It doesn't look like test() is defined anywhere. philipj_slow 2014/03/07 18:39:38 Oops. Copypasta. Show quoted text On 2014/03/07 17:45:04, acolwell wrote: > nit: Why is this needed? It doesn't look like test() is defined anywhere. Oops. Copypasta.
	8 <video controls></video>

	9 <script>

	10 if (window.testRunner)

	11 testRunner.waitUntilDone();

	12

	13 var video = document.querySelector("video");

	14 video.src = findMediaFile("video", "content/test");

	15 video.autoplay = true;

	16 video.addEventListener("playing", function()

	17 {

	18 video.currentTime = 3;
	acolwell GONE FROM CHROMIUM 2014/03/07 17:45:04 nit: Add a comment here and perhaps above the remo nit: Add a comment here and perhaps above the removeAttribute() call indicating why you are doing these things. I'm assuming this seek is so you can make the controls look different than their initial state and the removeAttribute is to verify that the controls return to their original state. philipj_slow 2014/03/07 18:39:38 Done. Show quoted text On 2014/03/07 17:45:04, acolwell wrote: > nit: Add a comment here and perhaps above the removeAttribute() call indicating > why you are doing these things. I'm assuming this seek is so you can make the > controls look different than their initial state and the removeAttribute is to > verify that the controls return to their original state. Done.
	19 video.addEventListener("seeked", function()

	20 {

	21 video.removeAttribute("src");

	22 video.load();

	23 video.addEventListener("emptied", function()

	24 {

	25 if (window.testRunner)

	26 testRunner.notifyDone();

	27 });

	28 });

	29 });

	30 </script>

	31 </body>

	32 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/media/controls-after-unload-expected.html » ('j') | no next file with comments »