VulkanViewer on Android

VulkanViewer on Android
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1903253003

Committed: https://skia.googlesource.com/skia/+/12d62a7d51a1826e221ffd34224d01c9bec49bab

[djsollen, 2016-04-20 17:39:15]

Description was changed from

==========
VulkanViewer on Android
==========

to

==========
VulkanViewer on Android
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[djsollen, 2016-04-20 17:39:46]

djsollen@google.com changed reviewers:
+ egdaniel@google.com, jvanverth@google.com

[djsollen, 2016-04-20 17:46:26]

greg or jim, can you verify that this doesn't break the windows vulkanviewer?

https://codereview.chromium.org/1903253003/diff/1/gyp/most.gyp
File gyp/most.gyp (left):

https://codereview.chromium.org/1903253003/diff/1/gyp/most.gyp#oldcode78
gyp/most.gyp:78: [ 'skia_vulkan == 0 or skia_os != "win"', {
do we still need to guard against including this on linux and mac?

[jvanverth1, 2016-04-20 17:56:26]

I can check tomorrow if need be. Some other changes will be needed to merge this
with my WSI patch (depending on which lands first).

https://codereview.chromium.org/1903253003/diff/1/gyp/most.gyp
File gyp/most.gyp (left):

https://codereview.chromium.org/1903253003/diff/1/gyp/most.gyp#oldcode78
gyp/most.gyp:78: [ 'skia_vulkan == 0 or skia_os != "win"', {
On 2016/04/20 17:46:26, djsollen wrote:
> do we still need to guard against including this on linux and mac?

Yes, we don't have a Linux version yet and Mac never will.

[egdaniel, 2016-04-20 19:40:52]

I have run this patch on my Win machine and Vulkan viewer (and all other parts
of Vulkan) seem to be working fine

[jvanverth1, 2016-04-21 14:02:54]

lgtm, with my limited knowledge of Android

[djsollen, 2016-04-21 14:47:29]

Description was changed from

==========
VulkanViewer on Android
==========

to

==========
VulkanViewer on Android
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[djsollen, 2016-04-21 14:48:16]

The CQ bit was checked by djsollen@google.com

[djsollen, 2016-04-21 14:48:17]

The patchset sent to the CQ was uploaded after l-g-t-m from jvanverth@google.com
Link to the patchset: https://codereview.chromium.org/1903253003/#ps20001
(title: "gyp")

[commit-bot: I haz the power, 2016-04-21 14:48:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1903253003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1903253003/20001

[commit-bot: I haz the power, 2016-04-21 14:59:46]

Description was changed from

==========
VulkanViewer on Android
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
VulkanViewer on Android
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/12d62a7d51a1826e221ffd34224d01c9bec49bab
==========

[commit-bot: I haz the power, 2016-04-21 14:59:47]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/12d62a7d51a1826e221ffd34224d01c9bec49bab