Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1903163002:
Don't compute a composited selection for a detached frame (Closed)
DescriptionDon't compute a composited selection for a detached frame
BUG=604558
Committed: https://crrev.com/47b2b4e6884185d18067746607f4f71cf02d77d4
Cr-Commit-Position: refs/heads/master@{#388531}
Patch Set 1 #
Messages
Total messages: 17 (10 generated)
Description was changed from ========== Don't compute a composited selection for a detached frame BUG=604558 ========== to ========== Don't compute a composited selection for a detached frame BUG=604558 ==========
skyostil@chromium.org changed reviewers: + wangxiaohan@gmail.com
Description was changed from ========== Don't compute a composited selection for a detached frame BUG=604558 ========== to ========== Don't compute a composited selection for a detached frame BUG=604558 TEST=Load page from bug report ==========
Description was changed from ========== Don't compute a composited selection for a detached frame BUG=604558 TEST=Load page from bug report ========== to ========== Don't compute a composited selection for a detached frame BUG=604558 ==========
skyostil@chromium.org changed reviewers: + wangxianzhu@chromium.org - wangxiaohan@gmail.com
Small fix for the previous change to avoid building a composited selection for throttled frames. PTAL. I couldn't figure out how to test this without also triggering https://bugs.chromium.org/p/chromium/issues/detail?id=605071 so I only tested this manually.
The CQ bit was checked by wangxianzhu@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1903163002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1903163002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...) chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...) chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
The CQ bit was checked by skyostil@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1903163002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1903163002/1
Message was sent while issue was closed.
Description was changed from ========== Don't compute a composited selection for a detached frame BUG=604558 ========== to ========== Don't compute a composited selection for a detached frame BUG=604558 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Don't compute a composited selection for a detached frame BUG=604558 ========== to ========== Don't compute a composited selection for a detached frame BUG=604558 Committed: https://crrev.com/47b2b4e6884185d18067746607f4f71cf02d77d4 Cr-Commit-Position: refs/heads/master@{#388531} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/47b2b4e6884185d18067746607f4f71cf02d77d4 Cr-Commit-Position: refs/heads/master@{#388531} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
