Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Side by Side Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 1903163002: Don't compute a composited selection for a detached frame (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999 Lars Knoll <knoll@kde.org> 3 * 1999 Lars Knoll <knoll@kde.org>
4 * 1999 Antti Koivisto <koivisto@kde.org> 4 * 1999 Antti Koivisto <koivisto@kde.org>
5 * 2000 Dirk Mueller <mueller@kde.org> 5 * 2000 Dirk Mueller <mueller@kde.org>
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com) 7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com)
8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * Copyright (C) 2009 Google Inc. All rights reserved. 9 * Copyright (C) 2009 Google Inc. All rights reserved.
10 * 10 *
(...skipping 1605 matching lines...) Expand 10 before | Expand all | Expand 10 after
1616 // layout. 1616 // layout.
1617 if (!m_nestedLayoutCount) { 1617 if (!m_nestedLayoutCount) {
1618 updateWidgetGeometries(); 1618 updateWidgetGeometries();
1619 if (LayoutView* layoutView = this->layoutView()) 1619 if (LayoutView* layoutView = this->layoutView())
1620 layoutView->layer()->setNeedsCompositingInputsUpdate(); 1620 layoutView->layer()->setNeedsCompositingInputsUpdate();
1621 } 1621 }
1622 } 1622 }
1623 1623
1624 bool FrameView::computeCompositedSelection(LocalFrame& frame, CompositedSelectio n& selection) 1624 bool FrameView::computeCompositedSelection(LocalFrame& frame, CompositedSelectio n& selection)
1625 { 1625 {
1626 if (frame.view()->shouldThrottleRendering()) 1626 if (!frame.view() || frame.view()->shouldThrottleRendering())
1627 return false; 1627 return false;
1628 1628
1629 const VisibleSelection& visibleSelection = frame.selection().selection(); 1629 const VisibleSelection& visibleSelection = frame.selection().selection();
1630 if (!visibleSelection.isCaretOrRange()) 1630 if (!visibleSelection.isCaretOrRange())
1631 return false; 1631 return false;
1632 1632
1633 // Non-editable caret selections lack any kind of UI affordance, and 1633 // Non-editable caret selections lack any kind of UI affordance, and
1634 // needn't be tracked by the client. 1634 // needn't be tracked by the client.
1635 if (visibleSelection.isCaret() && !visibleSelection.isContentEditable()) 1635 if (visibleSelection.isCaret() && !visibleSelection.isContentEditable())
1636 return false; 1636 return false;
(...skipping 2417 matching lines...) Expand 10 before | Expand all | Expand 10 after
4054 return m_hiddenForThrottling && m_crossOriginForThrottling; 4054 return m_hiddenForThrottling && m_crossOriginForThrottling;
4055 } 4055 }
4056 4056
4057 LayoutBox& FrameView::boxForScrollControlPaintInvalidation() const 4057 LayoutBox& FrameView::boxForScrollControlPaintInvalidation() const
4058 { 4058 {
4059 ASSERT(layoutView()); 4059 ASSERT(layoutView());
4060 return *layoutView(); 4060 return *layoutView();
4061 } 4061 }
4062 4062
4063 } // namespace blink 4063 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698