Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1298)

Unified Diff: content/browser/service_worker/embedded_worker_instance.cc

Issue 1903043005: service worker: Bump update time even when the script was identical (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix asan Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/service_worker/service_worker_job_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/service_worker/embedded_worker_instance.cc
diff --git a/content/browser/service_worker/embedded_worker_instance.cc b/content/browser/service_worker/embedded_worker_instance.cc
index 451a612d3ce6c8c4c0db474cdd3931c3fa0e2a2f..26a21bb43e3bd00882b0ae30502513880e7bc75c 100644
--- a/content/browser/service_worker/embedded_worker_instance.cc
+++ b/content/browser/service_worker/embedded_worker_instance.cc
@@ -561,8 +561,9 @@ void EmbeddedWorkerInstance::OnScriptLoaded() {
duration, source, inflight_start_task_->start_situation());
}
- FOR_EACH_OBSERVER(Listener, listener_list_, OnScriptLoaded());
starting_phase_ = SCRIPT_LOADED;
+ FOR_EACH_OBSERVER(Listener, listener_list_, OnScriptLoaded());
+ // |this| may be destroyed by the callback.
}
void EmbeddedWorkerInstance::OnURLJobCreatedForMainScript() {
« no previous file with comments | « no previous file | content/browser/service_worker/service_worker_job_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698