Issue 1903033002: Revert changes to event signatures as they broke one co19 test and this change isn't required due t…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1903033002: Revert changes to event signatures as they broke one co19 test and this change isn't required due t… (Closed)

Created:
4 years, 8 months ago by Jacob

Modified:
4 years, 8 months ago

Reviewers:
Alan Knight

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Revert changes to event signatures as they broke one co19 test and this change isn't required due to relaxation in types in EventStreamProvider.dart BUG= Committed: https://github.com/dart-lang/sdk/commit/068252e721026cd38e32552948ebc1148d0dabbb

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -27 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	9 chunks	+10 lines, -10 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	10 chunks	+12 lines, -12 lines	0 comments	Download
M	tools/dom/scripts/htmleventgenerator.py	View	5 chunks	+5 lines, -5 lines	0 comments	Download

Total messages: 5 (2 generated)

Jacob

Committed patchset #1 (id:1) manually as 068252e721026cd38e32552948ebc1148d0dabbb.

4 years, 8 months ago (2016-04-19 23:42:22 UTC) #4

Message was sent while issue was closed.

lgtm