Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1271)

Unified Diff: sdk/lib/html/dart2js/html_dart2js.dart

Issue 1903033002: Revert changes to event signatures as they broke one co19 test and this change isn't required due t… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « no previous file | sdk/lib/html/dartium/html_dartium.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/html/dart2js/html_dart2js.dart
diff --git a/sdk/lib/html/dart2js/html_dart2js.dart b/sdk/lib/html/dart2js/html_dart2js.dart
index f40ca41618c63acc49c33ebc249550d9ad68f951..3d48d6087af93ccc3e7e503cdef3075aec596fc8 100644
--- a/sdk/lib/html/dart2js/html_dart2js.dart
+++ b/sdk/lib/html/dart2js/html_dart2js.dart
@@ -143,12 +143,12 @@ abstract class AbstractWorker extends Interceptor implements EventTarget {
*/
@DomName('AbstractWorker.errorEvent')
@DocsEditable()
- static const EventStreamProvider<Event> errorEvent = const EventStreamProvider<Event>('error');
+ static const EventStreamProvider<ErrorEvent> errorEvent = const EventStreamProvider<ErrorEvent>('error');
/// Stream of `error` events handled by this [AbstractWorker].
@DomName('AbstractWorker.onerror')
@DocsEditable()
- Stream<Event> get onError => errorEvent.forTarget(this);
+ Stream<ErrorEvent> get onError => errorEvent.forTarget(this);
}
// Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
@@ -3201,7 +3201,7 @@ class CompositorWorker extends EventTarget implements AbstractWorker {
@DomName('CompositorWorker.errorEvent')
@DocsEditable()
@Experimental() // untriaged
- static const EventStreamProvider<Event> errorEvent = const EventStreamProvider<Event>('error');
+ static const EventStreamProvider<ErrorEvent> errorEvent = const EventStreamProvider<ErrorEvent>('error');
@DomName('CompositorWorker.messageEvent')
@DocsEditable()
@@ -3247,7 +3247,7 @@ class CompositorWorker extends EventTarget implements AbstractWorker {
@DomName('CompositorWorker.onerror')
@DocsEditable()
@Experimental() // untriaged
- Stream<Event> get onError => errorEvent.forTarget(this);
+ Stream<ErrorEvent> get onError => errorEvent.forTarget(this);
@DomName('CompositorWorker.onmessage')
@DocsEditable()
@@ -19634,7 +19634,7 @@ class HttpRequest extends HttpRequestEventTarget {
*/
@DomName('XMLHttpRequest.readystatechangeEvent')
@DocsEditable()
- static const EventStreamProvider<Event> readyStateChangeEvent = const EventStreamProvider<Event>('readystatechange');
+ static const EventStreamProvider<ProgressEvent> readyStateChangeEvent = const EventStreamProvider<ProgressEvent>('readystatechange');
/**
* General constructor for any type of request (GET, POST, etc).
@@ -19938,7 +19938,7 @@ class HttpRequest extends HttpRequestEventTarget {
*/
@DomName('XMLHttpRequest.onreadystatechange')
@DocsEditable()
- Stream<Event> get onReadyStateChange => readyStateChangeEvent.forTarget(this);
+ Stream<ProgressEvent> get onReadyStateChange => readyStateChangeEvent.forTarget(this);
}
// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
@@ -30052,7 +30052,7 @@ class SharedWorker extends EventTarget implements AbstractWorker {
@DomName('SharedWorker.errorEvent')
@DocsEditable()
@Experimental() // untriaged
- static const EventStreamProvider<Event> errorEvent = const EventStreamProvider<Event>('error');
+ static const EventStreamProvider<ErrorEvent> errorEvent = const EventStreamProvider<ErrorEvent>('error');
@DomName('SharedWorker.SharedWorker')
@DocsEditable()
@@ -30077,7 +30077,7 @@ class SharedWorker extends EventTarget implements AbstractWorker {
@DomName('SharedWorker.onerror')
@DocsEditable()
@Experimental() // untriaged
- Stream<Event> get onError => errorEvent.forTarget(this);
+ Stream<ErrorEvent> get onError => errorEvent.forTarget(this);
}
// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
@@ -36750,7 +36750,7 @@ class Worker extends EventTarget implements AbstractWorker {
@DomName('Worker.errorEvent')
@DocsEditable()
@Experimental() // untriaged
- static const EventStreamProvider<Event> errorEvent = const EventStreamProvider<Event>('error');
+ static const EventStreamProvider<ErrorEvent> errorEvent = const EventStreamProvider<ErrorEvent>('error');
/**
* Static factory designed to expose `message` events to event
@@ -36801,7 +36801,7 @@ class Worker extends EventTarget implements AbstractWorker {
@DomName('Worker.onerror')
@DocsEditable()
@Experimental() // untriaged
- Stream<Event> get onError => errorEvent.forTarget(this);
+ Stream<ErrorEvent> get onError => errorEvent.forTarget(this);
/// Stream of `message` events handled by this [Worker].
@DomName('Worker.onmessage')
« no previous file with comments | « no previous file | sdk/lib/html/dartium/html_dartium.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698