Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 1902923002: [remoting android] Refactor OAuthTokenFetcher for reusability (Closed)

Created:
4 years, 8 months ago by Lambros
Modified:
4 years, 8 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[remoting android] Refactor OAuthTokenFetcher for reusability This allows the class to be used in host code. * Token scope is passed in. * Removed hardcoded error-resources. * Moved into 'base' package, so it is separated from other client code. BUG=602355 Committed: https://crrev.com/fdcec667a89dd09237ceec8df301dc1ca5f88ae9 Cr-Commit-Position: refs/heads/master@{#388395}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -148 lines) Patch
M remoting/android/client_java_tmpl.gni View 2 chunks +1 line, -1 line 0 comments Download
M remoting/android/java/src/org/chromium/chromoting/Chromoting.java View 4 chunks +9 lines, -3 lines 0 comments Download
D remoting/android/java/src/org/chromium/chromoting/OAuthTokenFetcher.java View 1 chunk +0 lines, -131 lines 0 comments Download
A + remoting/android/java/src/org/chromium/chromoting/base/OAuthTokenFetcher.java View 5 chunks +16 lines, -13 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Lambros
4 years, 8 months ago (2016-04-19 18:45:39 UTC) #2
Sergey Ulanov
lgtm
4 years, 8 months ago (2016-04-20 00:04:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1902923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1902923002/1
4 years, 8 months ago (2016-04-20 00:08:52 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-20 01:17:08 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:19:38 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fdcec667a89dd09237ceec8df301dc1ca5f88ae9
Cr-Commit-Position: refs/heads/master@{#388395}

Powered by Google App Engine
This is Rietveld 408576698