Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1070)

Unified Diff: remoting/android/java/src/org/chromium/chromoting/Chromoting.java

Issue 1902923002: [remoting android] Refactor OAuthTokenFetcher for reusability (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/android/java/src/org/chromium/chromoting/Chromoting.java
diff --git a/remoting/android/java/src/org/chromium/chromoting/Chromoting.java b/remoting/android/java/src/org/chromium/chromoting/Chromoting.java
index 6fc8b7dd645c9f4ae0fc0a9bd206d73903d296d4..eccef48d4f70b3546f9dc09d493b2029d3ddc309 100644
--- a/remoting/android/java/src/org/chromium/chromoting/Chromoting.java
+++ b/remoting/android/java/src/org/chromium/chromoting/Chromoting.java
@@ -34,6 +34,7 @@ import org.chromium.base.ApiCompatibilityUtils;
import org.chromium.base.Log;
import org.chromium.chromoting.accountswitcher.AccountSwitcher;
import org.chromium.chromoting.accountswitcher.AccountSwitcherFactory;
+import org.chromium.chromoting.base.OAuthTokenFetcher;
import org.chromium.chromoting.help.HelpContext;
import org.chromium.chromoting.help.HelpSingleton;
import org.chromium.chromoting.jni.Client;
@@ -54,6 +55,10 @@ public class Chromoting extends AppCompatActivity implements ConnectionListener,
/** Only accounts of this type will be selectable for authentication. */
private static final String ACCOUNT_TYPE = "com.google";
+ /** Scope to use when fetching the OAuth token. */
+ private static final String TOKEN_SCOPE = "oauth2:https://www.googleapis.com/auth/chromoting "
+ + "https://www.googleapis.com/auth/googletalk";
+
/** Result code used for starting {@link DesktopActivity}. */
public static final int DESKTOP_ACTIVITY = 0;
@@ -494,7 +499,7 @@ public class Chromoting extends AppCompatActivity implements ConnectionListener,
private void requestAuthToken(boolean expireCurrentToken) {
mWaitingForAuthToken = true;
- OAuthTokenFetcher fetcher = new OAuthTokenFetcher(this, mAccount,
+ OAuthTokenFetcher fetcher = new OAuthTokenFetcher(this, mAccount, TOKEN_SCOPE,
new OAuthTokenFetcher.Callback() {
@Override
public void onTokenFetched(String token) {
@@ -504,10 +509,11 @@ public class Chromoting extends AppCompatActivity implements ConnectionListener,
}
@Override
- public void onError(int errorResource) {
+ public void onError(OAuthTokenFetcher.Error error) {
mWaitingForAuthToken = false;
updateHostListView();
- String explanation = getString(errorResource);
+ String explanation = getString(error == OAuthTokenFetcher.Error.NETWORK
+ ? R.string.error_network_error : R.string.error_unexpected);
Toast.makeText(Chromoting.this, explanation, Toast.LENGTH_LONG).show();
}
});
« no previous file with comments | « remoting/android/client_java_tmpl.gni ('k') | remoting/android/java/src/org/chromium/chromoting/OAuthTokenFetcher.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698