MD Settings: Display spinner and disable buttons while clearing browsing data.

MD Settings: Display spinner and disable buttons while clearing browsing data.

BUG=601208
Committed: https://crrev.com/a7a7084ea86c7fafcbe5cf0d4a3b4dda18b1e5cb
Cr-Commit-Position: refs/heads/master@{#388412}

[dpapad, 2016-04-19 19:34:21]

Patchset #1 (id:1) has been deleted

[dpapad, 2016-04-19 20:25:10]

dpapad@chromium.org changed reviewers:
+ dschuyler@chromium.org

[dpapad, 2016-04-19 20:25:11]

Screenshot at http://imgur.com/QSg5j2A.

[dpapad, 2016-04-19 20:26:17]

Description was changed from

==========
MD Settings: Display spinner and disable buttons while clearing.

BUG=601208
==========

to

==========
MD Settings: Display spinner and disable buttons while clearing browsing data.

BUG=601208
==========

[dschuyler, 2016-04-20 00:16:46]

https://codereview.chromium.org/1902873003/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html
(right):

https://codereview.chromium.org/1902873003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html:68:
<paper-button class="action-button" i18n-content="clearBrowsingData"
Please use the $i18n{} for the replacement.

https://codereview.chromium.org/1902873003/diff/20001/chrome/test/data/webui/...
File chrome/test/data/webui/settings/privacy_page_test.js (right):

https://codereview.chromium.org/1902873003/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/settings/privacy_page_test.js:129: }).then(function() {
Is starting a new function necessary here?

[dpapad, 2016-04-20 00:28:30]

https://codereview.chromium.org/1902873003/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html
(right):

https://codereview.chromium.org/1902873003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html:68:
<paper-button class="action-button" i18n-content="clearBrowsingData"
On 2016/04/20 at 00:16:46, dschuyler wrote:
> Please use the $i18n{} for the replacement.

Do you mind if I update this entire file in a separate CL? In this CL I am not
introducing any new replacements, I just removed the "id" property and
re-indented.

https://codereview.chromium.org/1902873003/diff/20001/chrome/test/data/webui/...
File chrome/test/data/webui/settings/privacy_page_test.js (right):

https://codereview.chromium.org/1902873003/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/settings/privacy_page_test.js:129: }).then(function() {
On 2016/04/20 at 00:16:46, dschuyler wrote:
> Is starting a new function necessary here?

Yes. This allows the code that waits for this Promise to resolve (and
consequently to hide the spinner, re-enable the buttons) to execute before the
assertions below occur.

[dpapad, 2016-04-20 01:20:16]

https://codereview.chromium.org/1902873003/diff/20001/chrome/test/data/webui/...
File chrome/test/data/webui/settings/privacy_page_test.js (right):

https://codereview.chromium.org/1902873003/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/settings/privacy_page_test.js:129: }).then(function() {
On 2016/04/20 at 00:28:30, dpapad wrote:
> On 2016/04/20 at 00:16:46, dschuyler wrote:
> > Is starting a new function necessary here?
> 
> Yes. This allows the code that waits for this Promise to resolve (and
consequently to hide the spinner, re-enable the buttons) to execute before the
assertions below occur.

Added a comment in latest patch explaining this.

[dschuyler, 2016-04-20 01:29:08]

LGTM (though there is a typo in the new comment).

https://codereview.chromium.org/1902873003/diff/40001/chrome/test/data/webui/...
File chrome/test/data/webui/settings/privacy_page_test.js (right):

https://codereview.chromium.org/1902873003/diff/40001/chrome/test/data/webui/...
chrome/test/data/webui/settings/privacy_page_test.js:129: // Yiels to the
message loop to allow the callback chain of the
Yields

[dpapad, 2016-04-20 01:34:02]

Thanks.

https://codereview.chromium.org/1902873003/diff/40001/chrome/test/data/webui/...
File chrome/test/data/webui/settings/privacy_page_test.js (right):

https://codereview.chromium.org/1902873003/diff/40001/chrome/test/data/webui/...
chrome/test/data/webui/settings/privacy_page_test.js:129: // Yiels to the
message loop to allow the callback chain of the
On 2016/04/20 at 01:29:08, dschuyler wrote:
> Yields

Fixed.

[dpapad, 2016-04-20 01:39:57]

The CQ bit was checked by dpapad@chromium.org

[dpapad, 2016-04-20 01:39:57]

The patchset sent to the CQ was uploaded after l-g-t-m from
dschuyler@chromium.org
Link to the patchset: https://codereview.chromium.org/1902873003/#ps60001
(title: "Fixed typo")

[commit-bot: I haz the power, 2016-04-20 01:40:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1902873003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1902873003/60001

[commit-bot: I haz the power, 2016-04-20 02:54:05]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-04-22 19:20:19]

Description was changed from

==========
MD Settings: Display spinner and disable buttons while clearing browsing data.

BUG=601208
==========

to

==========
MD Settings: Display spinner and disable buttons while clearing browsing data.

BUG=601208

Committed: https://crrev.com/a7a7084ea86c7fafcbe5cf0d4a3b4dda18b1e5cb
Cr-Commit-Position: refs/heads/master@{#388412}
==========

[commit-bot: I haz the power, 2016-04-22 19:20:20]

Patchset 3 (id:??) landed as
https://crrev.com/a7a7084ea86c7fafcbe5cf0d4a3b4dda18b1e5cb
Cr-Commit-Position: refs/heads/master@{#388412}