chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.js - Issue 1902873003: MD Settings: Display spinner and disable buttons while clearing browsing data.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.js

Issue 1902873003: MD Settings: Display spinner and disable buttons while clearing browsing data. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed typo Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html ('k') | chrome/test/data/webui/settings/cr_settings_browsertest.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.js

diff --git a/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.js b/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.js

index b6b045dd19967946b705b99c356b95eba3719a98..381b54fa47a5c5139a48b213d48722df2b386254 100644

--- a/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.js

+++ b/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.js

@@ -35,6 +35,9 @@ Polymer({

{value: 4, name: loadTimeData.getString('clearDataEverything')},

+ /** @private */

+ clearingInProgress_: Boolean,

/** @private {!settings.ClearBrowsingDataBrowserProxy} */

@@ -69,9 +72,9 @@ Polymer({

/** @private */

onClearBrowsingDataTap_: function() {

- // TODO(dpapad): Show spinner, disable buttons here.

+ this.clearingInProgress_ = true;

this.browserProxy_.clearBrowsingData().then(function() {

- // TODO(dpapad): Hide spinner, re-enable buttons here.

+ this.clearingInProgress_ = false;

this.$.dialog.close();

}.bind(this));