Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 1902833002: Revert of Base: add Optional<T>. (Closed)

Created:
4 years, 8 months ago by cmumford
Modified:
4 years, 8 months ago
CC:
chromium-reviews, dcheng, Sami
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Base: add Optional<T>. (patchset #15 id:280001 of https://codereview.chromium.org/1245163002/ ) Reason for revert: Unit tests failing on Windows-7-SP1. https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/47913 Original issue's description: > Base: add Optional<T>. > > This is an implementation of the C++17 std::optional<> feature: > http://en.cppreference.com/w/cpp/utility/optional > > Chromium documentation: > https://chromium.googlesource.com/chromium/src/+/master/docs/optional.md > > BUG=521269 > > Committed: https://crrev.com/8756e4f20df53bbb7fbb49b2ca19fda93a95bdb4 > Cr-Commit-Position: refs/heads/master@{#388187} TBR=danakj@chromium.org,dcheng@chromium.org,dmazzoni@chromium.org,horo@chromium.org,shivanisha@chromium.org,thakis@chromium.org,wfh@chromium.org,mlamouri@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=521269 Committed: https://crrev.com/77d44abe31b14e212cf9728b86054ae811fe3fdf Cr-Commit-Position: refs/heads/master@{#388216}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1762 lines) Patch
M base/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M base/base.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M base/base.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D base/optional.h View 1 chunk +0 lines, -427 lines 0 comments Download
D base/optional_unittest.cc View 1 chunk +0 lines, -1228 lines 0 comments Download
D docs/optional.md View 1 chunk +0 lines, -103 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
cmumford
Created Revert of Base: add Optional<T>.
4 years, 8 months ago (2016-04-19 15:59:12 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1902833002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1902833002/1
4 years, 8 months ago (2016-04-19 15:59:22 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-19 15:59:52 UTC) #4
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:12:36 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/77d44abe31b14e212cf9728b86054ae811fe3fdf
Cr-Commit-Position: refs/heads/master@{#388216}

Powered by Google App Engine
This is Rietveld 408576698