Introduce isHTMLTitleElement and toHTMLTitleElement

Introduce isHTMLTitleElement and toHTMLTitleElement

To avoid direct use of static_cast, this patch introduces isHTMLTitleElement and toHTMLTitleElement for code cleanup.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154003

[eseidel, 2013-07-11 01:24:00]

I believe inferno has been the one pushing for these functions.

https://codereview.chromium.org/19028005/diff/1/Source/core/html/HTMLTitleEle...
File Source/core/html/HTMLTitleElement.h (right):

https://codereview.chromium.org/19028005/diff/1/Source/core/html/HTMLTitleEle...
Source/core/html/HTMLTitleElement.h:54: inline bool isHTMLTitleElement(const
Element* element)
This one shouldn't be necessary, or?

[kangil_, 2013-07-11 01:34:34]

> I believe inferno has been the one pushing for these functions.
> 

Sorry but I don't understand the context here. Would you please elaborate it? :)

https://codereview.chromium.org/19028005/diff/1/Source/core/html/HTMLTitleEle...
File Source/core/html/HTMLTitleElement.h (right):

https://codereview.chromium.org/19028005/diff/1/Source/core/html/HTMLTitleEle...
Source/core/html/HTMLTitleElement.h:54: inline bool isHTMLTitleElement(const
Element* element)
On 2013/07/11 01:24:00, eseidel wrote:
> This one shouldn't be necessary, or?

Node::hasTagName includes Node::isElementNode and this is unnecessary trigger
for Element. So, IMHO, we need this. :)

[inferno, 2013-07-11 01:58:46]

lgtm

On 2013/07/11 01:34:34, kangil_ wrote:
> > I believe inferno has been the one pushing for these functions.
> > 
> 
> Sorry but I don't understand the context here. Would you please elaborate it?
:)

He meant that I was always interested in such patches as it catches bad casts ->
security vulns.

> 
>
https://codereview.chromium.org/19028005/diff/1/Source/core/html/HTMLTitleEle...
> File Source/core/html/HTMLTitleElement.h (right):
> 
>
https://codereview.chromium.org/19028005/diff/1/Source/core/html/HTMLTitleEle...
> Source/core/html/HTMLTitleElement.h:54: inline bool isHTMLTitleElement(const
> Element* element)
> On 2013/07/11 01:24:00, eseidel wrote:
> > This one shouldn't be necessary, or?
> 
> Node::hasTagName includes Node::isElementNode and this is unnecessary trigger
> for Element. So, IMHO, we need this. :)

Yes. We have this pattern all over the place -
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

[commit-bot: I haz the power, 2013-07-11 02:00:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kangil.han@samsung.com/19028005/1

[kangil_, 2013-07-11 02:43:36]

On 2013/07/11 01:58:46, inferno wrote:
> lgtm
> 
> On 2013/07/11 01:34:34, kangil_ wrote:
> > > I believe inferno has been the one pushing for these functions.
> > > 
> > 
> > Sorry but I don't understand the context here. Would you please elaborate
it?
> :)
> 
> He meant that I was always interested in such patches as it catches bad casts
->
> security vulns.
> 

Oh, I see! :)

[commit-bot: I haz the power, 2013-07-11 04:37:19]

Retried try job too often on win_layout_rel for step(s) webkit_tests,
webkit_unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout...

[commit-bot: I haz the power, 2013-07-11 04:47:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kangil.han@samsung.com/19028005/1

[commit-bot: I haz the power, 2013-07-11 05:17:44]

Retried try job too often on win_layout_rel for step(s) webkit_unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout...

[commit-bot: I haz the power, 2013-07-11 06:15:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kangil.han@samsung.com/19028005/1

[commit-bot: I haz the power, 2013-07-11 09:04:57]

Retried try job too often on win_layout_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout...

[commit-bot: I haz the power, 2013-07-11 10:50:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kangil.han@samsung.com/19028005/1

[commit-bot: I haz the power, 2013-07-11 13:08:42]

Retried try job too often on win_layout_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout...

[commit-bot: I haz the power, 2013-07-11 13:11:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kangil.han@samsung.com/19028005/1

[commit-bot: I haz the power, 2013-07-11 13:54:09]

Change committed as 154003