Source/core/editing/ReplaceSelectionCommand.cpp - Issue 19028005: Introduce isHTMLTitleElement and toHTMLTitleElement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/ReplaceSelectionCommand.cpp

Issue 19028005: Introduce isHTMLTitleElement and toHTMLTitleElement (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/editing/ReplaceSelectionCommand.cpp

diff --git a/Source/core/editing/ReplaceSelectionCommand.cpp b/Source/core/editing/ReplaceSelectionCommand.cpp

index 0185e5e36c3ac67c5ed764f2fed1adfca53c59a4..57b3718faa9b5faf22e1a0f729b12530b12c310c 100644

--- a/Source/core/editing/ReplaceSelectionCommand.cpp

+++ b/Source/core/editing/ReplaceSelectionCommand.cpp

@@ -51,6 +51,7 @@

#include "core/editing/markup.h"

#include "core/html/HTMLElement.h"

#include "core/html/HTMLInputElement.h"

+#include "core/html/HTMLTitleElement.h"

#include "core/page/Frame.h"

#include "core/rendering/RenderObject.h"

#include "core/rendering/RenderText.h"

@@ -703,7 +704,7 @@ static void removeHeadContents(ReplacementFragment& fragment)

|| node->hasTagName(linkTag)

|| node->hasTagName(metaTag)

|| node->hasTagName(styleTag)

- || node->hasTagName(titleTag)) {

+ || isHTMLTitleElement(node)) {

next = NodeTraversal::nextSkippingChildren(node);

fragment.removeNode(node);

} else

« no previous file with comments | « Source/core/dom/Document.cpp ('k') | Source/core/html/HTMLTitleElement.h » ('j') | Source/core/html/HTMLTitleElement.h » ('J')