Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issue 1902683005: Worker: Replace ASSERT macros with DCHECK macros (Closed)

Created:
4 years, 8 months ago by nhiroki
Modified:
4 years, 8 months ago
Reviewers:
tkent
CC:
blink-reviews, blink-worker-reviews_chromium.org, chromium-reviews, falken, horo+watch_chromium.org, kinuko+worker_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Worker: Replace ASSERT macros with DCHECK macros * ASSERT -> DCHECK * ASSERT_WITH_SECURITY_IMPLICATION -> SECURITY_DCHECK * ASSERT_NOT_REACHED -> NOTREACHED * ENABLE(ASSERT) -> DCHECK_IS_ON() NOTE: RELEASE_ASSERT is not replaced with CHECK in this CL because CHECK has a performance problem. See the following link for details. The background of this change: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/TL0NkNXIT1w BUG=596760 Committed: https://crrev.com/faf5a858a3d7d507ad4732abc25f8210ad0f79ce Cr-Commit-Position: refs/heads/master@{#388705}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -65 lines) Patch
M third_party/WebKit/Source/core/workers/DedicatedWorkerGlobalScope.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/workers/InProcessWorkerBase.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp View 10 chunks +15 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/workers/SharedWorker.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/workers/Worker.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerBackingThread.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerBackingThread.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerEventQueue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp View 6 chunks +11 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerInspectorProxy.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerLoaderProxy.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerLocation.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerScriptLoader.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerThread.cpp View 8 chunks +10 lines, -11 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
nhiroki
Kent-san, can you review this? Thanks! AFAICS, compile failures on bots are being caused by ...
4 years, 8 months ago (2016-04-21 02:08:35 UTC) #3
tkent
lgtm
4 years, 8 months ago (2016-04-21 03:58:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1902683005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1902683005/1
4 years, 8 months ago (2016-04-21 05:15:06 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-21 06:39:31 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:32:01 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/faf5a858a3d7d507ad4732abc25f8210ad0f79ce
Cr-Commit-Position: refs/heads/master@{#388705}

Powered by Google App Engine
This is Rietveld 408576698