Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Unified Diff: third_party/WebKit/Source/core/workers/WorkerScriptLoader.cpp

Issue 1902683005: Worker: Replace ASSERT macros with DCHECK macros (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/workers/WorkerScriptLoader.cpp
diff --git a/third_party/WebKit/Source/core/workers/WorkerScriptLoader.cpp b/third_party/WebKit/Source/core/workers/WorkerScriptLoader.cpp
index 12c1b85a3eaf0e1977d7963dd2c198c56b652ee1..d020fe22530d8757c698cdae3343e1a417ff34e0 100644
--- a/third_party/WebKit/Source/core/workers/WorkerScriptLoader.cpp
+++ b/third_party/WebKit/Source/core/workers/WorkerScriptLoader.cpp
@@ -70,7 +70,7 @@ void WorkerScriptLoader::loadSynchronously(ExecutionContext& executionContext, c
m_url = url;
ResourceRequest request(createResourceRequest(creationAddressSpace));
- ASSERT_WITH_SECURITY_IMPLICATION(executionContext.isWorkerGlobalScope());
+ SECURITY_DCHECK(executionContext.isWorkerGlobalScope());
ThreadableLoaderOptions options;
options.crossOriginRequestPolicy = crossOriginRequestPolicy;
@@ -85,7 +85,7 @@ void WorkerScriptLoader::loadSynchronously(ExecutionContext& executionContext, c
void WorkerScriptLoader::loadAsynchronously(ExecutionContext& executionContext, const KURL& url, CrossOriginRequestPolicy crossOriginRequestPolicy, WebAddressSpace creationAddressSpace, PassOwnPtr<SameThreadClosure> responseCallback, PassOwnPtr<SameThreadClosure> finishedCallback)
{
- ASSERT(responseCallback || finishedCallback);
+ DCHECK(responseCallback || finishedCallback);
m_responseCallback = responseCallback;
m_finishedCallback = finishedCallback;
m_url = url;
@@ -111,7 +111,7 @@ void WorkerScriptLoader::loadAsynchronously(ExecutionContext& executionContext,
const KURL& WorkerScriptLoader::responseURL() const
{
- ASSERT(!failed());
+ DCHECK(!failed());
return m_responseURL;
}
@@ -126,7 +126,7 @@ ResourceRequest WorkerScriptLoader::createResourceRequest(WebAddressSpace creati
void WorkerScriptLoader::didReceiveResponse(unsigned long identifier, const ResourceResponse& response, PassOwnPtr<WebDataConsumerHandle> handle)
{
- ASSERT_UNUSED(handle, !handle);
+ DCHECK(!handle);
if (response.httpStatusCode() / 100 != 2 && response.httpStatusCode()) {
notifyError();
return;
« no previous file with comments | « third_party/WebKit/Source/core/workers/WorkerLocation.h ('k') | third_party/WebKit/Source/core/workers/WorkerThread.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698