Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1228)

Unified Diff: third_party/WebKit/Source/core/streams/ReadableStreamController.h

Issue 1902673003: Reflect recent spec changes to V8 Extra ReadableStream impl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Some reordering Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/streams/ReadableStreamController.h
diff --git a/third_party/WebKit/Source/core/streams/ReadableStreamController.h b/third_party/WebKit/Source/core/streams/ReadableStreamController.h
index adc54f02601faaf6ad2d47512790bc71a62fb551..43d403b5dd089c74a5fc41946c98824aa9e7553c 100644
--- a/third_party/WebKit/Source/core/streams/ReadableStreamController.h
+++ b/third_party/WebKit/Source/core/streams/ReadableStreamController.h
@@ -51,7 +51,7 @@ public:
return;
v8::Local<v8::Value> args[] = { stream };
domenic 2016/04/27 21:12:24 Don't you need to pass the controller now, not the
tyoshino (SeeGerritForStatus) 2016/04/28 14:51:11 Right! Just forgot to. Done.
- V8ScriptRunner::callExtraOrCrash(scriptState, "CloseReadableStream", args);
+ V8ScriptRunner::callExtraOrCrash(scriptState, "ReadableStreamDefaultControllerClose", args);
m_stream.clear();
}
@@ -67,7 +67,7 @@ public:
return 0;
v8::Local<v8::Value> args[] = { stream };
- v8::Local<v8::Value> result = V8ScriptRunner::callExtraOrCrash(scriptState, "GetReadableStreamDesiredSize", args);
+ v8::Local<v8::Value> result = V8ScriptRunner::callExtraOrCrash(scriptState, "ReadableStreamDefaultControllerGetDesiredSize", args);
return result.As<v8::Number>()->Value();
}
@@ -85,7 +85,7 @@ public:
v8::Local<v8::Value> jsChunk = toV8(chunk, scriptState);
v8::Local<v8::Value> args[] = { stream, jsChunk };
- V8ScriptRunner::callExtraOrCrash(scriptState, "EnqueueInReadableStream", args);
+ V8ScriptRunner::callExtraOrCrash(scriptState, "ReadableStreamDefaultControllerEnqueue", args);
}
template <typename ErrorType>
@@ -101,7 +101,7 @@ public:
v8::Local<v8::Value> jsError = toV8(error, scriptState);
v8::Local<v8::Value> args[] = { stream, jsError };
- V8ScriptRunner::callExtraOrCrash(scriptState, "ErrorReadableStream", args);
+ V8ScriptRunner::callExtraOrCrash(scriptState, "ReadableStreamDefaultControllerError", args);
m_stream.clear();
}

Powered by Google App Engine
This is Rietveld 408576698