Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 1902593006: [Offline pages] Removing undoing of deleting offline pages (Closed)

Created:
4 years, 8 months ago by fgorski
Modified:
4 years, 8 months ago
Reviewers:
jianli
CC:
chromium-reviews, fgorski+watch_chromium.org, dimich+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@bookmarks-out
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Offline pages] Removing undoing of deleting offline pages * Removing Undo capability from offline page model * Removing marking pages for deletion * Removing relevant tests. Given that we no longer are bound to bookmarks or bookmarks UI there is no point in tracking existence thereof. When bookmark is deleted the offline copy is still around, until it expires. Once it does we clean it up. BUG=603940 R=jianli@chromium.org Committed: https://crrev.com/702d9d9c0afcc82a3f212a54082b373204baf711 Cr-Commit-Position: refs/heads/master@{#389032}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -288 lines) Patch
M components/offline_pages/offline_page_item.h View 1 chunk +0 lines, -8 lines 0 comments Download
M components/offline_pages/offline_page_item.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M components/offline_pages/offline_page_model.h View 4 chunks +0 lines, -24 lines 0 comments Download
M components/offline_pages/offline_page_model.cc View 15 chunks +17 lines, -158 lines 0 comments Download
M components/offline_pages/offline_page_model_unittest.cc View 1 chunk +0 lines, -86 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (4 generated)
jianli
lgtm
4 years, 8 months ago (2016-04-21 20:34:23 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1902593006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1902593006/1
4 years, 8 months ago (2016-04-22 03:43:17 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-22 04:23:26 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:44:31 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/702d9d9c0afcc82a3f212a54082b373204baf711
Cr-Commit-Position: refs/heads/master@{#389032}

Powered by Google App Engine
This is Rietveld 408576698