Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Unified Diff: components/offline_pages/offline_page_model.h

Issue 1902593006: [Offline pages] Removing undoing of deleting offline pages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bookmarks-out
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/offline_pages/offline_page_item.cc ('k') | components/offline_pages/offline_page_model.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/offline_pages/offline_page_model.h
diff --git a/components/offline_pages/offline_page_model.h b/components/offline_pages/offline_page_model.h
index 1cf601ec5feb8803cdf97975567c5dba816360e6..439dc6bf5240d6a473460247f0307a6af4d8857a 100644
--- a/components/offline_pages/offline_page_model.h
+++ b/components/offline_pages/offline_page_model.h
@@ -158,12 +158,6 @@ class OfflinePageModel : public KeyedService, public base::SupportsUserData {
// will be updated. Requires that the model is loaded.
void MarkPageAccessed(int64_t offline_id);
- // Marks that the offline page related to the passed |offline_id| was going
- // to be deleted. The deletion will occur in a short while. The undo can be
- // done before this. Requires that the model is loaded.
- void MarkPageForDeletion(int64_t offline_id,
- const DeletePageCallback& callback);
-
// Deletes an offline page related to the passed |offline_id|.
void DeletePageByOfflineId(int64_t offline_id,
const DeletePageCallback& callback);
@@ -172,11 +166,6 @@ class OfflinePageModel : public KeyedService, public base::SupportsUserData {
void DeletePagesByOfflineId(const std::vector<int64_t>& offline_ids,
const DeletePageCallback& callback);
- // Marks pages for deletion. Actual delete is asynchronous.
- // Works even if the model isn't loaded.
- void MarkPagesForDeletion(const std::vector<int64_t>& offline_ids,
- const DeletePageCallback& callback);
-
// Wipes out all the data by deleting all saved files and clearing the store.
void ClearAll(const base::Closure& callback);
@@ -241,10 +230,6 @@ class OfflinePageModel : public KeyedService, public base::SupportsUserData {
int64_t free_space_bytes,
bool reporting_after_delete);
- // Undo a deletion of a page. Pages that are marked for deletion can
- // be restored prior to when they are actually deleted.
- void UndoPageDeletion(int64_t offline_id);
-
// Methods for testing only:
OfflinePageMetadataStore* GetStoreForTesting();
@@ -301,15 +286,6 @@ class OfflinePageModel : public KeyedService, public base::SupportsUserData {
void OnMarkPageAccesseDone(const OfflinePageItem& offline_page_item,
bool success);
- // Steps for marking an offline page for deletion that can be undone.
- void OnMarkPageForDeletionDone(const OfflinePageItem& offline_page_item,
- const DeletePageCallback& callback,
- bool success);
- void FinalizePageDeletion();
-
- // Steps for undoing an offline page deletion.
- void OnUndoOfflinePageDone(const OfflinePageItem& offline_page, bool success);
-
// Callbacks for checking if offline pages are missing archive files.
void OnFindPagesMissingArchiveFile(
const std::vector<int64_t>* ids_of_pages_missing_archive_file);
« no previous file with comments | « components/offline_pages/offline_page_item.cc ('k') | components/offline_pages/offline_page_model.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698