Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Issue 1902263004: Mojo: Change the blink variant from "wtf" to "blink". (Closed)

Created:
4 years, 8 months ago by Sam McNally
Modified:
4 years, 8 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, blink-reviews, blink-reviews-api_chromium.org, chrome-apps-syd-reviews_chromium.org, chromium-reviews, darin (slow to review), dglazkov+blink, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo: Change the blink variant from "wtf" to "blink". BUG=596202 Committed: https://crrev.com/0c8396083e862032a031f843fd9087eb751f3227 Cr-Commit-Position: refs/heads/master@{#389704}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -157 lines) Patch
M device/usb/usb.gyp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M mojo/mojo_public.gyp View 1 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/mojom_bindings_generator.gypi View 1 1 chunk +26 lines, -22 lines 0 comments Download
M mojo/mojom_bindings_generator_explicit.gypi View 1 2 chunks +25 lines, -21 lines 0 comments Download
M mojo/public/cpp/bindings/tests/BUILD.gn View 1 2 3 3 chunks +3 lines, -2 lines 0 comments Download
M mojo/public/cpp/bindings/tests/pickle_unittest.cc View 1 2 3 5 chunks +8 lines, -8 lines 0 comments Download
M mojo/public/cpp/bindings/tests/rect_blink_traits.h View 1 chunk +4 lines, -3 lines 0 comments Download
M mojo/public/cpp/bindings/tests/struct_traits_unittest.cc View 6 chunks +9 lines, -9 lines 0 comments Download
M mojo/public/cpp/bindings/tests/wtf_types_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/public/tools/bindings/blink_bindings_configuration.gni View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/BUILD.gn View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentRequest.h View 4 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentRequest.cpp View 1 2 3 4 chunks +13 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentResponse.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentResponse.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentResponseTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/ShippingAddress.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/ShippingAddress.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/payments/ShippingAddressTest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/wake_lock/ScreenWakeLock.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webusb/USB.h View 1 2 3 3 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/modules/webusb/USB.cpp View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webusb/USBAlternateInterface.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webusb/USBAlternateInterface.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webusb/USBConfiguration.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webusb/USBConfiguration.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webusb/USBDevice.h View 1 2 3 4 chunks +14 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/modules/webusb/USBDevice.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webusb/USBEndpoint.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webusb/USBEndpoint.cpp View 1 2 3 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/webusb/USBInterface.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webusb/USBInterface.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/ScreenWakeLockTest.cpp View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/public/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/public/blink.gyp View 1 2 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 19 (7 generated)
Sam McNally
4 years, 8 months ago (2016-04-20 00:06:06 UTC) #2
haraken
LGTM
4 years, 8 months ago (2016-04-20 00:12:03 UTC) #3
yzshen1
https://codereview.chromium.org/1902263004/diff/1/mojo/mojo_public.gyp File mojo/mojo_public.gyp (right): https://codereview.chromium.org/1902263004/diff/1/mojo/mojo_public.gyp#newcode422 mojo/mojo_public.gyp:422: 'mojom_variant': 'blink', Now that we use a fixed variant ...
4 years, 8 months ago (2016-04-20 17:47:34 UTC) #4
Sam McNally
https://codereview.chromium.org/1902263004/diff/1/mojo/mojo_public.gyp File mojo/mojo_public.gyp (right): https://codereview.chromium.org/1902263004/diff/1/mojo/mojo_public.gyp#newcode422 mojo/mojo_public.gyp:422: 'mojom_variant': 'blink', On 2016/04/20 17:47:33, yzshen1 wrote: > Now ...
4 years, 8 months ago (2016-04-21 06:05:20 UTC) #7
yzshen1
lgtm
4 years, 8 months ago (2016-04-21 15:38:20 UTC) #8
Sam McNally
+rockot for mojo/ and device/
4 years, 8 months ago (2016-04-21 23:46:57 UTC) #10
Ken Rockot(use gerrit already)
lgtm
4 years, 8 months ago (2016-04-22 18:26:59 UTC) #11
Sam McNally
esprehn: ping
4 years, 8 months ago (2016-04-26 00:50:10 UTC) #12
esprehn
lgtm
4 years, 8 months ago (2016-04-26 00:55:41 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1902263004/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1902263004/100001
4 years, 8 months ago (2016-04-26 01:44:53 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:100001)
4 years, 8 months ago (2016-04-26 05:24:28 UTC) #17
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 05:25:30 UTC) #19
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/0c8396083e862032a031f843fd9087eb751f3227
Cr-Commit-Position: refs/heads/master@{#389704}

Powered by Google App Engine
This is Rietveld 408576698