Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 1902093005: Enable ReconcileWhenWhenBothPrefsTypesArrivesFromSync on iOS (Closed)

Created:
4 years, 8 months ago by vabr (Chromium)
Modified:
4 years, 8 months ago
Reviewers:
sdefresne
CC:
chromium-reviews, gcasto+watchlist_chromium.org, mkwst+watchlist-passwords_chromium.org, vabr+watchlistpasswordmanager_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable ReconcileWhenWhenBothPrefsTypesArrivesFromSync on iOS This CL enables PasswordManagerSettingMigratorServiceTest.ReconcileWhenWhenBothPrefsTypesArrivesFromSync on iOS, after https://codereview.chromium.org/1902113002/ fixed the test failure. BUG=604721 Committed: https://crrev.com/5760870a55360f410f3327597a1da57d1d806119 Cr-Commit-Position: refs/heads/master@{#388476}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -12 lines) Patch
M components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc View 1 chunk +1 line, -12 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1902093005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1902093005/1
4 years, 8 months ago (2016-04-20 10:27:28 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-20 10:58:13 UTC) #4
sdefresne
lgtm
4 years, 8 months ago (2016-04-20 12:25:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1902093005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1902093005/1
4 years, 8 months ago (2016-04-20 12:40:34 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-20 12:45:00 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:22:47 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5760870a55360f410f3327597a1da57d1d806119
Cr-Commit-Position: refs/heads/master@{#388476}

Powered by Google App Engine
This is Rietveld 408576698