Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Unified Diff: components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc

Issue 1902093005: Enable ReconcileWhenWhenBothPrefsTypesArrivesFromSync on iOS (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc
diff --git a/components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc b/components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc
index ce644d4a9a7bd95f94a178709d0a544c1671a200..c91203223d98aa95ac748128d678b08d3c613e35 100644
--- a/components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc
+++ b/components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc
@@ -264,19 +264,8 @@ TEST_F(PasswordManagerSettingMigratorServiceTest, TestMigrationOnLocalChanges) {
}
}
-// TODO(crbug.com/604721): original CL never compiled this file with gyp and
-// thus the test was never run on iOS and is now failing. Disabled until the
-// bug is fixed to unblock conversion to gn.
-#if !defined(OS_IOS)
-#define MAYBE_ReconcileWhenWhenBothPrefsTypesArrivesFromSync \
- ReconcileWhenWhenBothPrefsTypesArrivesFromSync
-#else
-#define MAYBE_ReconcileWhenWhenBothPrefsTypesArrivesFromSync \
- DISABLED_ReconcileWhenWhenBothPrefsTypesArrivesFromSync
-#endif
-
TEST_F(PasswordManagerSettingMigratorServiceTest,
- MAYBE_ReconcileWhenWhenBothPrefsTypesArrivesFromSync) {
+ ReconcileWhenWhenBothPrefsTypesArrivesFromSync) {
const struct {
BooleanPrefState new_pref_local_value;
BooleanPrefState old_pref_local_value;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698