VM: Remove redundant build target dart_product.

tools/testing/dart/runtime_configuration.dart

Index: tools/testing/dart/runtime_configuration.dart
diff --git a/tools/testing/dart/runtime_configuration.dart b/tools/testing/dart/runtime_configuration.dart
index 4edacc3acd712a7fbcdb377fa8b9e1536ff4e11a..f4d3b620674e06b9f424460078f42e7ec6a4692b 100644
--- a/tools/testing/dart/runtime_configuration.dart
+++ b/tools/testing/dart/runtime_configuration.dart
@@ -48,9 +48,6 @@ class RuntimeConfiguration {
       case 'vm':
         return new StandaloneDartRuntimeConfiguration();
 
-      case 'dart_product':
-        return new DartProductRuntimeConfiguration();
-
       case 'dart_precompiled':
         return new DartPrecompiledRuntimeConfiguration();
 
@@ -218,30 +215,6 @@ class StandaloneDartRuntimeConfiguration extends DartVmRuntimeConfiguration {
   }
 }
 
-class DartProductRuntimeConfiguration extends DartVmRuntimeConfiguration {
-  List<Command> computeRuntimeCommands(
-      TestSuite suite,
-      CommandBuilder commandBuilder,
-      CommandArtifact artifact,
-      List<String> arguments,
-      Map<String, String> environmentOverrides) {
-    String script = artifact.filename;
-    String type = artifact.mimeType;
-    if (script != null && type != 'application/dart-snapshot') {
-      throw "dart_product cannot run files of type '$type'.";
-    }
-
-    var augmentedArgs = new List();
-    augmentedArgs.add("--run-full-snapshot=${artifact.filename}");

[Cutch, 2016/04/19 19:19:28]

In product mode the test harness builds a full snapshot and runs that against
the product binary. It looks like this CL loses that.

[Florian Schneider, 2016/04/19 20:12:42]

Oops. Yes, restored with using 'dart' as a binary.

-    augmentedArgs.addAll(arguments);
-
-    return <Command>[
-      commandBuilder.getVmCommand(suite.dartVmProductBinaryFileName,
-          augmentedArgs, environmentOverrides)
-    ];
-  }
-}
-
 class DartPrecompiledRuntimeConfiguration extends DartVmRuntimeConfiguration {
   List<Command> computeRuntimeCommands(
       TestSuite suite,