VM: Remove redundant build target dart_product.

tools/testing/dart/runtime_configuration.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library runtime_configuration;
 
 import 'compiler_configuration.dart' show CommandArtifact;
 
 // TODO(ahe): Remove this import, we can precompute all the values required
 // from TestSuite once the refactoring is complete.
@@ skipping 30 matching lines @@
 
       case 'd8':
         return new D8RuntimeConfiguration();
 
       case 'none':
         return new NoneRuntimeConfiguration();
 
       case 'vm':
         return new StandaloneDartRuntimeConfiguration();
 
-      case 'dart_product':
-        return new DartProductRuntimeConfiguration();
-
       case 'dart_precompiled':
         return new DartPrecompiledRuntimeConfiguration();
 
       case 'drt':
         return new DrtRuntimeConfiguration();
 
       default:
         throw "Unknown runtime '$runtime'";
     }
   }
@@ skipping 147 matching lines @@
     }
     String executable = suite.configuration['noopt']
         ? suite.dartVmNooptBinaryFileName
         : suite.dartVmBinaryFileName;
     return <Command>[
       commandBuilder.getVmCommand(executable, arguments, environmentOverrides)
     ];
   }
 }
 
-class DartProductRuntimeConfiguration extends DartVmRuntimeConfiguration {
-  List<Command> computeRuntimeCommands(
-      TestSuite suite,
-      CommandBuilder commandBuilder,
-      CommandArtifact artifact,
-      List<String> arguments,
-      Map<String, String> environmentOverrides) {
-    String script = artifact.filename;
-    String type = artifact.mimeType;
-    if (script != null && type != 'application/dart-snapshot') {
-      throw "dart_product cannot run files of type '$type'.";
-    }
-
-    var augmentedArgs = new List();
-    augmentedArgs.add("--run-full-snapshot=${artifact.filename}");

[Cutch, 2016/04/19 19:19:28]

In product mode the test harness builds a full snapshot and runs that against
the product binary. It looks like this CL loses that.

[Florian Schneider, 2016/04/19 20:12:42]

Oops. Yes, restored with using 'dart' as a binary.

-    augmentedArgs.addAll(arguments);
-
-    return <Command>[
-      commandBuilder.getVmCommand(suite.dartVmProductBinaryFileName,
-          augmentedArgs, environmentOverrides)
-    ];
-  }
-}
-
 class DartPrecompiledRuntimeConfiguration extends DartVmRuntimeConfiguration {
   List<Command> computeRuntimeCommands(
       TestSuite suite,
       CommandBuilder commandBuilder,
       CommandArtifact artifact,
       List<String> arguments,
       Map<String, String> environmentOverrides) {
     String script = artifact.filename;
     String type = artifact.mimeType;
     if (script != null && type != 'application/dart-precompiled') {
@@ skipping 17 matching lines @@
 class DummyRuntimeConfiguration extends DartVmRuntimeConfiguration {
   List<Command> computeRuntimeCommands(
       TestSuite suite,
       CommandBuilder commandBuilder,
       CommandArtifact artifact,
       List<String> arguments,
       Map<String, String> environmentOverrides) {
     throw "Unimplemented runtime '$runtimeType'";
   }
 }