VM: Remove redundant build target dart_product.

VM: Remove redundant build target dart_product.

It has been replaced by out/Product<arch>/dart

Building and testing product mode works via the -mproduct flag
with build.py/test.py.

BUG=
R=johnmccutchan@google.com

Committed: https://github.com/dart-lang/sdk/commit/e905d64058cfc07c8f5f8e2c048f8e040774d41e

[Florian Schneider, 2016-04-19 18:37:17]

fschneider@google.com changed reviewers:
+ asiva@google.com, johnmccutchan@google.com

[Cutch, 2016-04-19 19:19:28]

https://codereview.chromium.org/1902073003/diff/1/tools/testing/dart/runtime_...
File tools/testing/dart/runtime_configuration.dart (left):

https://codereview.chromium.org/1902073003/diff/1/tools/testing/dart/runtime_...
tools/testing/dart/runtime_configuration.dart:235:
augmentedArgs.add("--run-full-snapshot=${artifact.filename}");
In product mode the test harness builds a full snapshot and runs that against
the product binary. It looks like this CL loses that.

[Florian Schneider, 2016-04-19 20:12:42]

Ptal

https://codereview.chromium.org/1902073003/diff/1/tools/testing/dart/runtime_...
File tools/testing/dart/runtime_configuration.dart (left):

https://codereview.chromium.org/1902073003/diff/1/tools/testing/dart/runtime_...
tools/testing/dart/runtime_configuration.dart:235:
augmentedArgs.add("--run-full-snapshot=${artifact.filename}");
On 2016/04/19 19:19:28, Cutch wrote:
> In product mode the test harness builds a full snapshot and runs that against
> the product binary. It looks like this CL loses that.

Oops. Yes, restored with using 'dart' as a binary.

[Cutch, 2016-04-19 21:05:47]

lgtm

[Florian Schneider, 2016-04-20 10:29:09]

Description was changed from

==========
VM: Remove redundant build target dart_product.

It has been replaced by out/Product<arch>/dart

Building and testing product mode works via the -mproduct flag
with build.py/test.py.

BUG=
==========

to

==========
VM: Remove redundant build target dart_product.

It has been replaced by out/Product<arch>/dart

Building and testing product mode works via the -mproduct flag
with build.py/test.py.

BUG=
R=johnmccutchan@google.com

Committed:
https://github.com/dart-lang/sdk/commit/e905d64058cfc07c8f5f8e2c048f8e040774d41e
==========

[Florian Schneider, 2016-04-20 10:29:11]

Committed patchset #2 (id:20001) manually as
e905d64058cfc07c8f5f8e2c048f8e040774d41e (presubmit successful).

[siva, 2016-04-26 01:40:04]

https://codereview.chromium.org/1902073003/diff/20001/runtime/bin/main.cc
File runtime/bin/main.cc (right):

https://codereview.chromium.org/1902073003/diff/20001/runtime/bin/main.cc#new...
runtime/bin/main.cc:803: }
We don't want the service isolate to be started in product mode, how do you
assert that the isolate being started is not a service isolate?

[Florian Schneider, 2016-04-28 11:51:51]

https://codereview.chromium.org/1902073003/diff/20001/runtime/bin/main.cc
File runtime/bin/main.cc (right):

https://codereview.chromium.org/1902073003/diff/20001/runtime/bin/main.cc#new...
runtime/bin/main.cc:803: }
On 2016/04/26 01:40:04, siva wrote:
> We don't want the service isolate to be started in product mode, how do you
> assert that the isolate being started is not a service isolate?

Right now we don't have a product mode with assertions enabled, so we can't.
Maybe we would need something like PRODUCT_ASSERT?