third_party/WebKit/Source/core/layout/svg/LayoutSVGHiddenContainer.cpp - Issue 1902073002: Hoist "layout size changed" check out of SVGLayoutSupport::layoutChildren

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGHiddenContainer.cpp

Issue 1902073002: Hoist "layout size changed" check out of SVGLayoutSupport::layoutChildren (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@svg-container-layout-cleanup-2

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp ('k') | third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGHiddenContainer.cpp

diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGHiddenContainer.cpp b/third_party/WebKit/Source/core/layout/svg/LayoutSVGHiddenContainer.cpp

index 3961d888d0349e6063e00be58bc349481b706f29..d1979aa6d556e40dc767737975409630113c1d3a 100644

--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGHiddenContainer.cpp

+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGHiddenContainer.cpp

@@ -35,7 +35,13 @@ void LayoutSVGHiddenContainer::layout()

LayoutAnalyzer::Scope analyzer(*this);

// TODO(fs): In what cases do we need this?

bool transformChanged = SVGLayoutSupport::transformToRootChanged(this);

- SVGLayoutSupport::layoutChildren(this, selfNeedsLayout(), transformChanged);

+ // When hasRelativeLengths() is false, no descendants have relative lengths

+ // (hence no one is interested in viewport size changes).

+ bool layoutSizeChanged = element()->hasRelativeLengths()

+ && SVGLayoutSupport::layoutSizeOfNearestViewportChanged(this);

+ SVGLayoutSupport::layoutChildren(this, selfNeedsLayout(), transformChanged, layoutSizeChanged);

updateCachedBoundaries();

clearNeedsLayout();

}