Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 1902053003: Fix issue with doclava download when building varying revisions (Closed)

Created:
4 years, 8 months ago by pauljensen
Modified:
4 years, 8 months ago
Reviewers:
agrieve
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix issue with doclava download when building varying revisions If the expanded directory does not exist, delete the tarball otherwise if the tarball exists and the SHA1 hash matches, download_from_google_storage will not download and extract, and any tools depending on the expanded directory will fail.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M build/android/download_doclava.py View 1 chunk +10 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
pauljensen
Andrew, PTAL. Thank you!
4 years, 8 months ago (2016-04-19 16:49:57 UTC) #2
agrieve
On 2016/04/19 16:49:57, pauljensen wrote: > Andrew, PTAL. Thank you! lgtm
4 years, 8 months ago (2016-04-19 17:06:07 UTC) #3
agrieve
On 2016/04/19 17:06:07, agrieve wrote: > On 2016/04/19 16:49:57, pauljensen wrote: > > Andrew, PTAL. ...
4 years, 8 months ago (2016-04-19 17:08:00 UTC) #4
pauljensen
4 years, 8 months ago (2016-04-19 17:35:56 UTC) #5
On 2016/04/19 17:08:00, agrieve wrote:
> On 2016/04/19 17:06:07, agrieve wrote:
> > On 2016/04/19 16:49:57, pauljensen wrote:
> > > Andrew, PTAL. Thank you!
> > 
> > lgtm
> 
> Actually, not lgtm. I think probably the fix should go in
> download_from_google_storage:
>
https://code.google.com/p/chromium/codesearch#chromium/tools/depot_tools/down...
> 
> --extract isn't used much, and this will likely bite the next person that
tries
> to use it as well.

I started https://codereview.chromium.org/1904483002

Powered by Google App Engine
This is Rietveld 408576698