Force download and extract if extracted directory is missing

Force download and extract if extracted directory is missing

Without this change, the extracted directory could be missing but
the downloaded file could match the hash, and in turn
download_from_google_storage will not download the file and will
not extract it, and any tools depending on the extracted
directory will fail.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300051

[pauljensen, 2016-04-19 17:42:58]

pauljensen@chromium.org changed reviewers:
+ hinoka@chromium.org

[pauljensen, 2016-04-19 17:42:59]

Hinoka, PTAL.  This came from https://codereview.chromium.org/1902053003/

[Ryan Tseng, 2016-04-19 21:07:51]

hinoka@google.com changed reviewers:
+ hinoka@google.com

[Ryan Tseng, 2016-04-19 21:07:52]

lgtm % nit.  Scoping looks a little funky even if it technically would work.

This wouldn't help with the case where the folder exist but the contents are
invalid (due to some external process mucking with them), but I suspect you
aren't worried about that case?

https://codereview.chromium.org/1904483002/diff/1/download_from_google_storag...
File download_from_google_storage.py (right):

https://codereview.chromium.org/1904483002/diff/1/download_from_google_storag...
download_from_google_storage.py:223: return
extract_dir = None

[pauljensen, 2016-04-20 11:37:00]

On 2016/04/19 21:07:52, Ryan Tseng wrote:
> This wouldn't help with the case where the folder exist but the contents are
> invalid (due to some external process mucking with them), but I suspect you
> aren't worried about that case?
It would not help with that case, but there isn't much we can do in that case
unless we re-extract every time (seems like a waste) or if we hashed the
directory contents which would be a fair bit more work.

https://codereview.chromium.org/1904483002/diff/1/download_from_google_storag...
File download_from_google_storage.py (right):

https://codereview.chromium.org/1904483002/diff/1/download_from_google_storag...
download_from_google_storage.py:223: return
On 2016/04/19 21:07:52, Ryan Tseng wrote:
> extract_dir = None

Done.

[pauljensen, 2016-04-20 11:38:22]

The CQ bit was checked by pauljensen@chromium.org

[pauljensen, 2016-04-20 11:38:22]

The patchset sent to the CQ was uploaded after l-g-t-m from hinoka@google.com
Link to the patchset: https://codereview.chromium.org/1904483002/#ps20001
(title: "init extract_dir")

[commit-bot: I haz the power, 2016-04-20 11:38:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1904483002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1904483002/20001

[commit-bot: I haz the power, 2016-04-20 11:38:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-20 11:38:29]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-infra-committers".
Note that this has nothing to do with OWNERS files.

[pauljensen, 2016-04-20 11:39:53]

Ryan, can you l-g-t-m from your @chromium.org account please?

[hinoka, 2016-04-20 18:45:34]

drat, i thought that would've worked

lgtm

[pauljensen, 2016-04-20 18:46:15]

The CQ bit was checked by pauljensen@chromium.org

[commit-bot: I haz the power, 2016-04-20 18:46:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1904483002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1904483002/20001

[commit-bot: I haz the power, 2016-04-20 18:48:56]

Description was changed from

==========
Force download and extract if extracted directory is missing

Without this change, the extracted directory could be missing but
the downloaded file could match the hash, and in turn
download_from_google_storage will not download the file and will
not extract it, and any tools depending on the extracted
directory will fail.
==========

to

==========
Force download and extract if extracted directory is missing

Without this change, the extracted directory could be missing but
the downloaded file could match the hash, and in turn
download_from_google_storage will not download the file and will
not extract it, and any tools depending on the extracted
directory will fail.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300051
==========

[commit-bot: I haz the power, 2016-04-20 18:48:57]

Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=300051