Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1902003003: [Extensions] Have Binding inherit from null proto (Closed)

Created:
4 years, 8 months ago by Devlin
Modified:
4 years, 8 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Have Binding inherit from null proto BUG=591164 BUG=604901 Committed: https://crrev.com/1affd84d7a57f498ba529892b97721fcd2d47afb Cr-Commit-Position: refs/heads/master@{#388375}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M extensions/renderer/resources/binding.js View 2 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
Devlin
4 years, 8 months ago (2016-04-20 00:12:17 UTC) #4
asargent_no_longer_on_chrome
lgtm
4 years, 8 months ago (2016-04-20 00:17:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1902003003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1902003003/20001
4 years, 8 months ago (2016-04-20 00:18:19 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 8 months ago (2016-04-20 00:26:56 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:18:50 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/1affd84d7a57f498ba529892b97721fcd2d47afb
Cr-Commit-Position: refs/heads/master@{#388375}

Powered by Google App Engine
This is Rietveld 408576698