Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(675)

Issue 1901813002: Revert "Add a crash for debugging when we get into a bad state." (Closed)

Created:
4 years, 8 months ago by Elliot Glaysher
Modified:
4 years, 8 months ago
Reviewers:
danakj, Tom Anderson
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Add a crash for debugging when we get into a bad state." This reverts commit 56cc0f5cd062625b39f7e4d1f326313ea010383b. We're actually seeing this crash in the wild. Let's see if we can craft a workaround to the bug now that we know this. TBR=danakj@chromium.org BUG=381732 Committed: https://crrev.com/d3c20a16015c13ca35a01a70657c6ec95f85cc55 Cr-Commit-Position: refs/heads/master@{#387994}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc View 3 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Elliot Glaysher
4 years, 8 months ago (2016-04-18 19:17:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1901813002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1901813002/1
4 years, 8 months ago (2016-04-18 19:17:44 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-18 20:07:38 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 20:08:45 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d3c20a16015c13ca35a01a70657c6ec95f85cc55
Cr-Commit-Position: refs/heads/master@{#387994}

Powered by Google App Engine
This is Rietveld 408576698