Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Side by Side Diff: ui/views/widget/desktop_aura/desktop_window_tree_host_x11.h

Issue 1901813002: Revert "Add a crash for debugging when we get into a bad state." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef UI_VIEWS_WIDGET_DESKTOP_AURA_DESKTOP_WINDOW_TREE_HOST_X11_H_ 5 #ifndef UI_VIEWS_WIDGET_DESKTOP_AURA_DESKTOP_WINDOW_TREE_HOST_X11_H_
6 #define UI_VIEWS_WIDGET_DESKTOP_AURA_DESKTOP_WINDOW_TREE_HOST_X11_H_ 6 #define UI_VIEWS_WIDGET_DESKTOP_AURA_DESKTOP_WINDOW_TREE_HOST_X11_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 #include <X11/extensions/shape.h> 10 #include <X11/extensions/shape.h>
(...skipping 241 matching lines...) Expand 10 before | Expand all | Expand 10 after
252 ::Window xwindow_; 252 ::Window xwindow_;
253 253
254 // The native root window. 254 // The native root window.
255 ::Window x_root_window_; 255 ::Window x_root_window_;
256 256
257 ui::X11AtomCache atom_cache_; 257 ui::X11AtomCache atom_cache_;
258 258
259 // Is the window mapped to the screen? 259 // Is the window mapped to the screen?
260 bool window_mapped_; 260 bool window_mapped_;
261 261
262 // Keeps track of whether we have ever mapped/withdrawn this
263 // window. Debugging information in trying to track down crbug.com/381732.
264 bool x_map_window_was_called_ = false;
265
266 // The bounds of |xwindow_|. 262 // The bounds of |xwindow_|.
267 gfx::Rect bounds_in_pixels_; 263 gfx::Rect bounds_in_pixels_;
268 264
269 // Whenever the bounds are set, we keep the previous set of bounds around so 265 // Whenever the bounds are set, we keep the previous set of bounds around so
270 // we can have a better chance of getting the real 266 // we can have a better chance of getting the real
271 // |restored_bounds_in_pixels_|. Window managers tend to send a Configure 267 // |restored_bounds_in_pixels_|. Window managers tend to send a Configure
272 // message with the maximized bounds, and then set the window maximized 268 // message with the maximized bounds, and then set the window maximized
273 // property. (We don't rely on this for when we request that the window be 269 // property. (We don't rely on this for when we request that the window be
274 // maximized, only when we detect that some other process has requested that 270 // maximized, only when we detect that some other process has requested that
275 // we become the maximized window.) 271 // we become the maximized window.)
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
353 base::CancelableCallback<void()> delayed_resize_task_; 349 base::CancelableCallback<void()> delayed_resize_task_;
354 350
355 base::WeakPtrFactory<DesktopWindowTreeHostX11> close_widget_factory_; 351 base::WeakPtrFactory<DesktopWindowTreeHostX11> close_widget_factory_;
356 352
357 DISALLOW_COPY_AND_ASSIGN(DesktopWindowTreeHostX11); 353 DISALLOW_COPY_AND_ASSIGN(DesktopWindowTreeHostX11);
358 }; 354 };
359 355
360 } // namespace views 356 } // namespace views
361 357
362 #endif // UI_VIEWS_WIDGET_DESKTOP_AURA_DESKTOP_WINDOW_TREE_HOST_X11_H_ 358 #endif // UI_VIEWS_WIDGET_DESKTOP_AURA_DESKTOP_WINDOW_TREE_HOST_X11_H_
OLDNEW
« no previous file with comments | « no previous file | ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698