[regexp] do not assume short external strings have a minimum size.

[regexp] do not assume short external strings have a minimum size.

Short external strings do not cache the resource data, and may be used
for compressible strings. The assumptions about their lengths is
invalid and may lead to oob reads.

R=jkummerow@chromium.org
BUG=v8:4923, chromium:604897
LOG=N

Committed: https://crrev.com/3518e492c0939759ae1a2623bbd606646ee172f1
Cr-Commit-Position: refs/heads/master@{#35660}

[Yang, 2016-04-18 12:04:52]

Description was changed from

==========
[regexp] do not assume short external strings have a minimum size.

Short external strings do not cache the resource data, and may be used
for compressible strings. The assumptions about their lengths is
invalid and may lead to oob reads.


R=jkummerow@chromium.org
BUG=v8:4923
==========

to

==========
[regexp] do not assume short external strings have a minimum size.

Short external strings do not cache the resource data, and may be used
for compressible strings. The assumptions about their lengths is
invalid and may lead to oob reads.


R=jkummerow@chromium.org
BUG=v8:4923
LOG=N
==========

[Yang, 2016-04-18 12:05:51]

Patchset #2 (id:20001) has been deleted

[Jakob Kummerow, 2016-04-18 12:45:13]

Looking good, waiting for ports.

https://codereview.chromium.org/1901573003/diff/1/src/ia32/code-stubs-ia32.cc
File src/ia32/code-stubs-ia32.cc (right):

https://codereview.chromium.org/1901573003/diff/1/src/ia32/code-stubs-ia32.cc...
src/ia32/code-stubs-ia32.cc:782: // ebx: subject string instance type
outdated comment

[Yang, 2016-04-18 12:48:40]

Addressed comment.

@v8-mips-ports: could you guys provide a port of this to mips and mips64?
thanks.

https://codereview.chromium.org/1901573003/diff/1/src/ia32/code-stubs-ia32.cc
File src/ia32/code-stubs-ia32.cc (right):

https://codereview.chromium.org/1901573003/diff/1/src/ia32/code-stubs-ia32.cc...
src/ia32/code-stubs-ia32.cc:782: // ebx: subject string instance type
On 2016/04/18 12:45:13, Jakob wrote:
> outdated comment

Done.

[akos.palfi.imgtec, 2016-04-18 15:22:33]

On 2016/04/18 12:48:40, Yang wrote:
> Addressed comment.
> 
> @v8-mips-ports: could you guys provide a port of this to mips and mips64?
> thanks.
> 
We're on it. :)

[Yang, 2016-04-20 09:14:01]

On 2016/04/18 15:22:33, akos.palfi.imgtec wrote:
> On 2016/04/18 12:48:40, Yang wrote:
> > Addressed comment.
> > 
> > @v8-mips-ports: could you guys provide a port of this to mips and mips64?
> > thanks.
> > 
> We're on it. :)

I fixed the mips ports to not crash, though they still fail the test. I'd like
to land it like this.

Jakob, can you finish reviewing this CL? Thanks.

[Jakob Kummerow, 2016-04-20 13:14:14]

lgtm

[Yang, 2016-04-20 13:21:41]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-20 13:21:50]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1901573003/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1901573003/140001

[Yang, 2016-04-20 13:31:07]

Description was changed from

==========
[regexp] do not assume short external strings have a minimum size.

Short external strings do not cache the resource data, and may be used
for compressible strings. The assumptions about their lengths is
invalid and may lead to oob reads.


R=jkummerow@chromium.org
BUG=v8:4923
LOG=N
==========

to

==========
[regexp] do not assume short external strings have a minimum size.

Short external strings do not cache the resource data, and may be used
for compressible strings. The assumptions about their lengths is
invalid and may lead to oob reads.


R=jkummerow@chromium.org
BUG=v8:4923,chromium:604897
LOG=N
==========

[commit-bot: I haz the power, 2016-04-20 13:47:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-20 13:47:17]

Dry run: This issue passed the CQ dry run.

[Yang, 2016-04-20 13:53:24]

The CQ bit was checked by yangguo@chromium.org

[commit-bot: I haz the power, 2016-04-20 13:53:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1901573003/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1901573003/140001

[commit-bot: I haz the power, 2016-04-20 13:55:25]

Description was changed from

==========
[regexp] do not assume short external strings have a minimum size.

Short external strings do not cache the resource data, and may be used
for compressible strings. The assumptions about their lengths is
invalid and may lead to oob reads.


R=jkummerow@chromium.org
BUG=v8:4923,chromium:604897
LOG=N
==========

to

==========
[regexp] do not assume short external strings have a minimum size.

Short external strings do not cache the resource data, and may be used
for compressible strings. The assumptions about their lengths is
invalid and may lead to oob reads.


R=jkummerow@chromium.org
BUG=v8:4923,chromium:604897
LOG=N
==========

[commit-bot: I haz the power, 2016-04-20 13:55:26]

Committed patchset #7 (id:140001)

[nodir1, 2016-04-22 18:44:14]

Description was changed from

==========
[regexp] do not assume short external strings have a minimum size.

Short external strings do not cache the resource data, and may be used
for compressible strings. The assumptions about their lengths is
invalid and may lead to oob reads.


R=jkummerow@chromium.org
BUG=v8:4923,chromium:604897
LOG=N
==========

to

==========
[regexp] do not assume short external strings have a minimum size.

Short external strings do not cache the resource data, and may be used
for compressible strings. The assumptions about their lengths is
invalid and may lead to oob reads.

R=jkummerow@chromium.org
BUG=v8:4923,chromium:604897
LOG=N

Committed: https://crrev.com/3518e492c0939759ae1a2623bbd606646ee172f1
Cr-Commit-Position: refs/heads/master@{#35660}
==========

[nodir1, 2016-04-22 18:44:15]

Patchset 7 (id:??) landed as
https://crrev.com/3518e492c0939759ae1a2623bbd606646ee172f1
Cr-Commit-Position: refs/heads/master@{#35660}