Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 1901573003: [regexp] do not assume short external strings have a minimum size. (Closed)

Created:
4 years, 8 months ago by Yang
Modified:
4 years, 8 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com, v8-mips-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp] do not assume short external strings have a minimum size. Short external strings do not cache the resource data, and may be used for compressible strings. The assumptions about their lengths is invalid and may lead to oob reads. R=jkummerow@chromium.org BUG=v8:4923, chromium:604897 LOG=N Committed: https://crrev.com/3518e492c0939759ae1a2623bbd606646ee172f1 Cr-Commit-Position: refs/heads/master@{#35660}

Patch Set 1 #

Total comments: 2

Patch Set 2 : x64 port #

Patch Set 3 : arm and arm64 ports #

Patch Set 4 : addressed comments #

Patch Set 5 : fix mips build #

Patch Set 6 : apply mips patch #

Patch Set 7 : mips port. functional mips64 port not available yet. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -219 lines) Patch
M src/arm/code-stubs-arm.cc View 1 2 3 4 5 chunks +28 lines, -39 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 2 3 4 5 chunks +34 lines, -46 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 2 3 4 6 chunks +30 lines, -45 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 2 3 4 5 7 chunks +27 lines, -40 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 2 3 4 6 1 chunk +0 lines, -3 lines 0 comments Download
M src/objects.h View 1 2 3 4 5 1 chunk +0 lines, -3 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 2 3 4 7 chunks +29 lines, -43 lines 0 comments Download
M test/cctest/cctest.status View 1 2 3 4 5 6 1 chunk +3 lines, -0 lines 0 comments Download
M test/cctest/test-regexp.cc View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
Yang
4 years, 8 months ago (2016-04-18 10:48:06 UTC) #1
Jakob Kummerow
Looking good, waiting for ports. https://codereview.chromium.org/1901573003/diff/1/src/ia32/code-stubs-ia32.cc File src/ia32/code-stubs-ia32.cc (right): https://codereview.chromium.org/1901573003/diff/1/src/ia32/code-stubs-ia32.cc#newcode782 src/ia32/code-stubs-ia32.cc:782: // ebx: subject string ...
4 years, 8 months ago (2016-04-18 12:45:13 UTC) #4
Yang
Addressed comment. @v8-mips-ports: could you guys provide a port of this to mips and mips64? ...
4 years, 8 months ago (2016-04-18 12:48:40 UTC) #5
akos.palfi.imgtec
On 2016/04/18 12:48:40, Yang wrote: > Addressed comment. > > @v8-mips-ports: could you guys provide ...
4 years, 8 months ago (2016-04-18 15:22:33 UTC) #6
Yang
On 2016/04/18 15:22:33, akos.palfi.imgtec wrote: > On 2016/04/18 12:48:40, Yang wrote: > > Addressed comment. ...
4 years, 8 months ago (2016-04-20 09:14:01 UTC) #7
Jakob Kummerow
lgtm
4 years, 8 months ago (2016-04-20 13:14:14 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1901573003/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1901573003/140001
4 years, 8 months ago (2016-04-20 13:21:50 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-20 13:47:17 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1901573003/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1901573003/140001
4 years, 8 months ago (2016-04-20 13:53:26 UTC) #15
commit-bot: I haz the power
Committed patchset #7 (id:140001)
4 years, 8 months ago (2016-04-20 13:55:26 UTC) #17
nodir1
4 years, 8 months ago (2016-04-22 18:44:15 UTC) #19
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/3518e492c0939759ae1a2623bbd606646ee172f1
Cr-Commit-Position: refs/heads/master@{#35660}

Powered by Google App Engine
This is Rietveld 408576698