src/objects.h - Issue 1901573003: [regexp] do not assume short external strings have a minimum size.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.h

Issue 1901573003: [regexp] do not assume short external strings have a minimum size. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: mips port. functional mips64 port not available yet. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/objects.h

diff --git a/src/objects.h b/src/objects.h

index fece0b232d8328ec7e29133a20b6acee0cf280d5..53b70beb6fa3971a07449fcb0d8a4d5729c7fcf5 100644

--- a/src/objects.h

+++ b/src/objects.h

@@ -9238,9 +9238,6 @@ class ExternalString: public String {

static const int kResourceDataOffset = kResourceOffset + kPointerSize;

static const int kSize = kResourceDataOffset + kPointerSize;

- static const int kMaxShortLength =

- (kShortSize - SeqString::kHeaderSize) / kCharSize;

// Return whether external string is short (data pointer is not cached).

inline bool is_short();

« no previous file with comments | « src/mips64/code-stubs-mips64.cc ('k') | src/x64/code-stubs-x64.cc » ('j') | no next file with comments »