Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1901473003: 🐞 Update version of third_party/ijar (Closed)

Created:
4 years, 8 months ago by agrieve
Modified:
4 years, 8 months ago
Reviewers:
Yaron
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update version of third_party/ijar Newer version contains some minor performance improvements as well as code to compute CRC32s BUG=604273 Committed: https://crrev.com/c2f2384a648e056c373113d4ae5b1f98c179f1cb Cr-Commit-Position: refs/heads/master@{#387916}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1405 lines, -304 lines) Patch
M third_party/ijar/BUILD.gn View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/ijar/README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M third_party/ijar/classfile.cc View 33 chunks +416 lines, -90 lines 0 comments Download
M third_party/ijar/common.h View 3 chunks +13 lines, -3 lines 0 comments Download
M third_party/ijar/ijar.cc View 3 chunks +13 lines, -9 lines 0 comments Download
A third_party/ijar/mapped_file.h View 1 chunk +82 lines, -0 lines 0 comments Download
A third_party/ijar/mapped_file_unix.cc View 1 chunk +147 lines, -0 lines 0 comments Download
A third_party/ijar/mapped_file_windows.cc View 1 chunk +216 lines, -0 lines 0 comments Download
M third_party/ijar/zip.h View 2 chunks +6 lines, -2 lines 0 comments Download
M third_party/ijar/zip.cc View 29 chunks +352 lines, -139 lines 0 comments Download
M third_party/ijar/zip_main.cc View 7 chunks +153 lines, -60 lines 0 comments Download

Dependent Patchsets:

Issue 1894013002 Patch 1

Messages

Total messages: 10 (5 generated)
agrieve
On 2016/04/18 14:28:04, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:yfriedman@chromium.org
4 years, 8 months ago (2016-04-18 14:28:46 UTC) #3
Yaron
lgtm
4 years, 8 months ago (2016-04-18 14:44:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1901473003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1901473003/1
4 years, 8 months ago (2016-04-18 15:05:36 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-18 15:53:10 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 15:55:17 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/c2f2384a648e056c373113d4ae5b1f98c179f1cb
Cr-Commit-Position: refs/heads/master@{#387916}

Powered by Google App Engine
This is Rietveld 408576698