Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(943)

Issue 1894013002: 🐟 Make Android Lint use interface jars (Closed)

Created:
4 years, 8 months ago by agrieve
Modified:
4 years, 8 months ago
Reviewers:
Yaron
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@ijar-update
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make Android Lint use interface jars Speeds it up a bit, and makes linting not run when classpath interface is not changed. BUG=604273 Committed: https://crrev.com/80d741694a3e11f06c21c289121da41f11436809 Cr-Commit-Position: refs/heads/master@{#387945}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M build/android/gyp/util/build_utils.py View 1 chunk +0 lines, -3 lines 0 comments Download
M build/config/android/internal_rules.gni View 1 chunk +1 line, -1 line 0 comments Download
M third_party/ijar/README.chromium View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/ijar/ijar.cc View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (5 generated)
agrieve
On 2016/04/18 14:28:26, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:yfriedman@chromium.org
4 years, 8 months ago (2016-04-18 14:28:35 UTC) #3
Yaron
lgtm
4 years, 8 months ago (2016-04-18 14:42:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1894013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1894013002/1
4 years, 8 months ago (2016-04-18 16:44:27 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-18 17:47:21 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 17:49:53 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/80d741694a3e11f06c21c289121da41f11436809
Cr-Commit-Position: refs/heads/master@{#387945}

Powered by Google App Engine
This is Rietveld 408576698