Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 190143003: Don't enforce signin for the settings app. (Closed)

Created:
6 years, 9 months ago by benwells
Modified:
6 years, 9 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Don't enforce signin for the settings app. The main use of the settings app is to switch profiles in the app when you are signed out. For this to be useful it is important that the sign in enforcement does not happen for the settings app. BUG=347025 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255881

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/ui/extensions/application_launch.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
benwells
6 years, 9 months ago (2014-03-07 08:35:10 UTC) #1
koz (OOO until 15th September)
lgtm
6 years, 9 months ago (2014-03-07 19:18:11 UTC) #2
koz (OOO until 15th September)
The CQ bit was checked by koz@chromium.org
6 years, 9 months ago (2014-03-07 19:18:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/190143003/1
6 years, 9 months ago (2014-03-07 19:19:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/190143003/1
6 years, 9 months ago (2014-03-07 20:25:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/190143003/1
6 years, 9 months ago (2014-03-08 10:53:06 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-08 14:20:11 UTC) #7
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) telemetry_perf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=234331
6 years, 9 months ago (2014-03-08 14:20:12 UTC) #8
benwells
The CQ bit was checked by benwells@chromium.org
6 years, 9 months ago (2014-03-09 21:20:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/190143003/1
6 years, 9 months ago (2014-03-09 21:20:46 UTC) #10
commit-bot: I haz the power
6 years, 9 months ago (2014-03-10 06:20:56 UTC) #11
Message was sent while issue was closed.
Change committed as 255881

Powered by Google App Engine
This is Rietveld 408576698