chrome/browser/ui/extensions/application_launch.cc - Issue 190143003: Don't enforce signin for the settings app.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/extensions/application_launch.cc

Issue 190143003: Don't enforce signin for the settings app. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/extensions/application_launch.cc

diff --git a/chrome/browser/ui/extensions/application_launch.cc b/chrome/browser/ui/extensions/application_launch.cc

index 2e4cd22bb08f489540d72f4c01c6676ae9372876..9328bebe1fedcbd9659b028f812edeaba3e60332 100644

--- a/chrome/browser/ui/extensions/application_launch.cc

+++ b/chrome/browser/ui/extensions/application_launch.cc

@@ -345,7 +345,8 @@ WebContents* OpenEnabledApplication(const AppLaunchParams& params) {

#if !defined(OS_CHROMEOS)

SigninManager* signin_manager =

SigninManagerFactory::GetForProfile(profile);

- if (signin_manager && signin_manager->GetAuthenticatedUsername().empty()) {

+ if (extension->id() != extension_misc::kSettingsAppId &&

+ signin_manager && signin_manager->GetAuthenticatedUsername().empty()) {

const char kEnforceSigninToUseAppsFieldTrial[] = "EnforceSigninToUseApps";

std::string field_trial_value =

« no previous file with comments | « no previous file | no next file » | no next file with comments »