Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 1901423002: Always include js-getter as separate field in AccessorInfo (Closed)

Created:
4 years, 8 months ago by Toon Verwaest
Modified:
4 years, 8 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Always include js-getter as separate field in AccessorInfo Due to cross-compilation from simulator-builds into non-simulator with snapshot it's complicated to conditionally include an extra field. Given that the memory overhead should be minimal, just always include a separate field instead. BUG= Committed: https://crrev.com/89606003af4768f633344adf1b847de2f446ce1b Cr-Commit-Position: refs/heads/master@{#35652}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -16 lines) Patch
M src/accessors.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/api.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/external-reference-table.cc View 1 2 3 1 chunk +1 line, -3 lines 0 comments Download
M src/objects.h View 2 chunks +0 lines, -6 lines 0 comments Download
M src/objects.cc View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M src/snapshot/serializer-common.cc View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
Toon Verwaest
ptal
4 years, 8 months ago (2016-04-20 08:30:48 UTC) #2
Yang
On 2016/04/20 08:30:48, Toon Verwaest wrote: > ptal lgtm.
4 years, 8 months ago (2016-04-20 08:47:09 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1901423002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1901423002/60001
4 years, 8 months ago (2016-04-20 08:48:50 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-20 09:15:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1901423002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1901423002/60001
4 years, 8 months ago (2016-04-20 09:51:36 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 8 months ago (2016-04-20 09:53:39 UTC) #10
nodir1
4 years, 8 months ago (2016-04-22 18:43:59 UTC) #12
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/89606003af4768f633344adf1b847de2f446ce1b
Cr-Commit-Position: refs/heads/master@{#35652}

Powered by Google App Engine
This is Rietveld 408576698