src/api.cc - Issue 1901423002: Always include js-getter as separate field in AccessorInfo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/api.cc

Issue 1901423002: Always include js-getter as separate field in AccessorInfo (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/api.cc

diff --git a/src/api.cc b/src/api.cc

index f8066053d6bccd98ded3bfc65724b8157d08682d..6b6f80f795debf708f1882772eea5a3ade12dd98 100644

--- a/src/api.cc

+++ b/src/api.cc

@@ -1238,10 +1238,8 @@ i::Handle<i::AccessorInfo> MakeAccessorInfo(

setter = reinterpret_cast<Setter>(&i::Accessors::ReconfigureToDataProperty);

}

SET_FIELD_WRAPPED(obj, set_setter, setter);

-#ifdef USE_SIMULATOR

i::Address redirected = obj->redirected_getter();

if (redirected != nullptr) SET_FIELD_WRAPPED(obj, set_js_getter, redirected);

-#endif

if (data.IsEmpty()) {

data = v8::Undefined(reinterpret_cast<v8::Isolate*>(isolate));

}

« no previous file with comments | « src/accessors.cc ('k') | src/external-reference-table.cc » ('j') | no next file with comments »