Remove UserAgent ShadowRoot + Author ShadowRoot code.

Remove UserAgent ShadowRoot + Author ShadowRoot code.

The code is not used since crrev.com/378921.
This CL removes Element::willAddFirstAuthorShadowRoot, which was added to
support this feature.

This CL adds ShadowRootType stream printer because ShadowRootType is used in
DCHECK_NE().

BUG=489947
Committed: https://crrev.com/d1f4ffde531b13089a1ec74bc1e2509bafca85a9
Cr-Commit-Position: refs/heads/master@{#388634}

[tkent, 2016-04-20 07:31:51]

Description was changed from

==========
Remove UserAgent ShadowRoot + Author ShadowRoot code.

The code is not used since crrev.com/378921.
This CL removes Element::willAddFirstAuthorShadowRoot, which was added to
support this feature.

BUG=489947
==========

to

==========
Remove UserAgent ShadowRoot + Author ShadowRoot code.

The code is not used since crrev.com/378921.
This CL removes Element::willAddFirstAuthorShadowRoot, which was added to
support this feature.

This CL adds ShadowRootType steam printer because ShadowRootType is used in
DCHECK_NE().

BUG=489947
==========

[tkent, 2016-04-20 07:32:12]

tkent@chromium.org changed reviewers:
+ hayato@chromium.org, kochi@chromium.org

[tkent, 2016-04-20 07:32:12]

kochi@ or hayato@, would you review this please?

[tkent, 2016-04-20 07:41:54]

Description was changed from

==========
Remove UserAgent ShadowRoot + Author ShadowRoot code.

The code is not used since crrev.com/378921.
This CL removes Element::willAddFirstAuthorShadowRoot, which was added to
support this feature.

This CL adds ShadowRootType steam printer because ShadowRootType is used in
DCHECK_NE().

BUG=489947
==========

to

==========
Remove UserAgent ShadowRoot + Author ShadowRoot code.

The code is not used since crrev.com/378921.
This CL removes Element::willAddFirstAuthorShadowRoot, which was added to
support this feature.

This CL adds ShadowRootType stream printer because ShadowRootType is used in
DCHECK_NE().

BUG=489947
==========

[kochi, 2016-04-20 07:46:52]

On 2016/04/20 07:32:12, tkent wrote:
> kochi@ or hayato@, would you review this please?

[kochi, 2016-04-20 07:47:08]

On 2016/04/20 07:46:52, kochi wrote:
> On 2016/04/20 07:32:12, tkent wrote:
> > kochi@ or hayato@, would you review this please?

I'll take a look.

[hayato, 2016-04-20 07:51:11]

LGTM

We do not have any layout tests for that?

[hayato, 2016-04-20 07:52:28]

On 2016/04/20 at 07:51:11, hayato wrote:
> LGTM
> 
> We do not have any layout tests for that?

Ops. I have already removed the tests in crrev.com/378921. :)

[kochi, 2016-04-20 07:57:22]

lgtm

[kochi, 2016-04-20 08:21:07]

https://codereview.chromium.org/1901403002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/shadow/ShadowRoot.cpp (right):

https://codereview.chromium.org/1901403002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/shadow/ShadowRoot.cpp:354: std::ostream&
operator<<(std::ostream& ostream, const ShadowRootType& type)
Can this be compiled in only when DCHECK() is enabled?

[tkent, 2016-04-20 08:31:05]

https://codereview.chromium.org/1901403002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/shadow/ShadowRoot.cpp (right):

https://codereview.chromium.org/1901403002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/shadow/ShadowRoot.cpp:354: std::ostream&
operator<<(std::ostream& ostream, const ShadowRootType& type)
On 2016/04/20 at 08:21:07, kochi wrote:
> Can this be compiled in only when DCHECK() is enabled?

Yes.  Done.  Release build doesn't need this function for now.

If we use EXPECT_EQ(ShadowRootType::Open, ...) in unit tests, we need this
function even in Release build.

[tkent, 2016-04-20 08:31:27]

The CQ bit was checked by tkent@chromium.org

[tkent, 2016-04-20 08:31:27]

The patchset sent to the CQ was uploaded after l-g-t-m from hayato@chromium.org,
kochi@chromium.org
Link to the patchset: https://codereview.chromium.org/1901403002/#ps20001
(title: "Wrap operator<< with DCHECK_IS_ON()")

[commit-bot: I haz the power, 2016-04-20 08:31:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1901403002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1901403002/20001

[tkent, 2016-04-20 08:32:12]

The CQ bit was unchecked by tkent@chromium.org

[tkent, 2016-04-20 09:05:41]

Patchset #3 (id:40001) has been deleted

[tkent, 2016-04-20 09:06:57]

tkent@chromium.org changed reviewers:
+ yosin@chromium.org

[tkent, 2016-04-20 09:06:57]

Please take another look.  I found some tests failed, and
Element::createShadowRoot didn't work for alwaysCreateUserAgentShadowRoot()
case.

+yosin for TextIteratorTest.cpp.

[kochi, 2016-04-20 09:25:34]

lgtm

[tkent, 2016-04-20 21:47:22]

The CQ bit was checked by tkent@chromium.org

[tkent, 2016-04-20 21:47:23]

The patchset sent to the CQ was uploaded after l-g-t-m from hayato@chromium.org
Link to the patchset: https://codereview.chromium.org/1901403002/#ps60001
(title: "Fix Element::createShadowRoot, update some tests")

[commit-bot: I haz the power, 2016-04-20 21:47:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1901403002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1901403002/60001

[commit-bot: I haz the power, 2016-04-21 00:28:49]

Committed patchset #3 (id:60001)

[Ken Russell (switch to Gerrit), 2016-04-21 01:23:41]

On 2016/04/21 00:28:49, commit-bot: I haz the power wrote:
> Committed patchset #3 (id:60001)

This caused this build breakage:
https://build.chromium.org/p/chromium.gpu/builders/GPU%20Win%20Builder/builds...

but I'm not sure how it got past the commit queue.

[tkent, 2016-04-21 01:56:21]

On 2016/04/21 at 01:23:41, kbr wrote:
> This caused this build breakage:
>
https://build.chromium.org/p/chromium.gpu/builders/GPU%20Win%20Builder/builds...
> 
> but I'm not sure how it got past the commit queue.

I landed a fix.
I think we don't have Release without DCHECK_IS_ON() coverage.

[commit-bot: I haz the power, 2016-04-22 19:28:54]

Description was changed from

==========
Remove UserAgent ShadowRoot + Author ShadowRoot code.

The code is not used since crrev.com/378921.
This CL removes Element::willAddFirstAuthorShadowRoot, which was added to
support this feature.

This CL adds ShadowRootType stream printer because ShadowRootType is used in
DCHECK_NE().

BUG=489947
==========

to

==========
Remove UserAgent ShadowRoot + Author ShadowRoot code.

The code is not used since crrev.com/378921.
This CL removes Element::willAddFirstAuthorShadowRoot, which was added to
support this feature.

This CL adds ShadowRootType stream printer because ShadowRootType is used in
DCHECK_NE().

BUG=489947

Committed: https://crrev.com/d1f4ffde531b13089a1ec74bc1e2509bafca85a9
Cr-Commit-Position: refs/heads/master@{#388634}
==========

[commit-bot: I haz the power, 2016-04-22 19:28:55]

Patchset 3 (id:??) landed as
https://crrev.com/d1f4ffde531b13089a1ec74bc1e2509bafca85a9
Cr-Commit-Position: refs/heads/master@{#388634}