third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp - Issue 1901403002: Remove UserAgent ShadowRoot + Author ShadowRoot code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp

Issue 1901403002: Remove UserAgent ShadowRoot + Author ShadowRoot code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix Element::createShadowRoot, update some tests Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp b/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp

index 1da1e93109033462b7d7b84b131ae44c13d6fbdd..9c3e5a948a0cb28dd1e21f5d12af8e3e60db8419 100644

--- a/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp

@@ -586,11 +586,6 @@ void HTMLPlugInElement::didAddUserAgentShadowRoot(ShadowRoot&)

userAgentShadowRoot()->appendChild(HTMLContentElement::create(document()));

}

-void HTMLPlugInElement::willAddFirstAuthorShadowRoot()

- lazyReattachIfAttached();

bool HTMLPlugInElement::hasFallbackContent() const

{

return false;

@@ -598,7 +593,7 @@ bool HTMLPlugInElement::hasFallbackContent() const

bool HTMLPlugInElement::useFallbackContent() const

{

- return openShadowRoot();

+ return false;

}

void HTMLPlugInElement::lazyReattachIfNeeded()

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLPlugInElement.h ('k') | no next file » | no next file with comments »